From: Pablo Neira <pablo@eurodev.net>
To: Amin Azez <azez@ufomechanic.net>
Cc: netfilter-devel@lists.netfilter.org,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Subject: Re: [PATCH] Conntrack proc interface for tuple removal
Date: Thu, 19 May 2005 05:10:28 +0200 [thread overview]
Message-ID: <428C03A4.7060401@eurodev.net> (raw)
In-Reply-To: <Pine.LNX.4.58.0505180847060.9582@blackhole.kfki.hu>
Jozsef Kadlecsik wrote:
> On Tue, 17 May 2005, Amin Azez wrote:
>
>
>>Pablo Neira wrote:
>>
>>>- READ_LOCK'ing while trying to delete a conntrack is racy, you must use
>>>write_lock instead. Someone else could be reading the conntrack table
>>>while you try to delete a conntrack.
>>>- check the value returned by del_timer, currently racy as well.
>>>- Deadlock on SMP: calling conntrack->timeout.function
>>>(death_by_timeout) is illegal if you've got ip_conntrack_lock.
>>
>>Where should one read to learn about the rules and intricacies of such
>>locking dependancies.
>
>
> Rusty's 'Unreliable Guide To Locking' is an excellent paper on the locking
> issues in the Linux kernel.
Robert Love has also written some stuff about this. Look for "Kernel
locking techniques". It could help you out together with Rusty's stuff.
--
Pablo
next prev parent reply other threads:[~2005-05-19 3:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-12 18:47 [PATCH] Conntrack proc interface for tuple removal Ferry Huberts
2005-05-13 5:13 ` Pablo Neira
2005-05-17 16:00 ` Amin Azez
2005-05-18 6:51 ` Jozsef Kadlecsik
2005-05-19 3:10 ` Pablo Neira [this message]
2005-05-17 16:00 ` Amin Azez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=428C03A4.7060401@eurodev.net \
--to=pablo@eurodev.net \
--cc=azez@ufomechanic.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.