From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Hopwood <david.nospam.hopwood@blueyonder.co.uk>
Subject: Re: [PATCH] vmx-gdbserver-sstep.patch
Date: Thu, 19 May 2005 19:59:22 +0100
Message-ID: <428CE20A.9040808@blueyonder.co.uk>
References: <20050519022405.GA31028@intel.com>
Reply-To: david.nospam.hopwood@blueyonder.co.uk
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20050519022405.GA31028@intel.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Arun Sharma wrote:
> +static inline int __vm_set_bit(unsigned long field, unsigned long mask)
> +{
> +        unsigned long tmp;
> +        int err = 0;
> +
> +        err |= __vmread(field, &tmp);
> +        tmp |= mask;
> +        err |= __vmwrite(field, tmp);

Wouldn't this be better:

   err = __vmread(field, &tmp);
   tmp |= mask;
   if (err == 0) err = __vmwrite(field, tmp);

(and similarly for __vm_clear_bit)?

-- 
David Hopwood <david.nospam.hopwood@blueyonder.co.uk>