Re: [PATCH] Fix git-fsck-cache segfault on invalid tag

[Frank Sorenson <frank@tuxrocks.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Petr Baudis wrote:
> Dear diary, on Fri, May 20, 2005 at 09:00:41AM CEST, I got a letter
> where Frank Sorenson <frank@tuxrocks.com> told me that...
> 
>>git-fsck-cache will segfault if a tag contains a non-existent sha1.  This
>>patch fixes fsck-cache to report the invalid tag and not die.
> 
> 
> Oh. I've fixed this too but didn't even get to commit it yet. :-)

Okay.  At least we fixed the same bug.  It was a good exercise for me to
track it down anyway :)

> My error message is
> 
> 	error("%s: invalid sha1 pointer %.40s", path, hexname);
> 
> I'd prefer that (at least use the error() call). The .40 is there since
> it has a newline on its own.

Great.  Your message looks fine.  It looks like error() should work fine
as well.

Frank
- --
Frank Sorenson - KD7TZK
Systems Manager, Computer Science Department
Brigham Young University
frank@tuxrocks.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCjfXgaI0dwg4A47wRAikrAKCvPmZBQK34sdnnY61/meuewu2jzQCfT7Qf
TDSNgfp3WBJOTvWG5uhwX4s=
=CUF2
-----END PGP SIGNATURE-----