From: Jeff Garzik <jgarzik@pobox.com>
To: Michael Chan <mchan@broadcom.com>, davem@davemloft.net
Cc: netdev@oss.sgi.com, ffan@broadcom.com, lusinsky@broadcom.com
Subject: Re: A new driver for Broadcom bcm5706
Date: Fri, 20 May 2005 16:51:46 -0400 [thread overview]
Message-ID: <428E4DE2.1020002@pobox.com> (raw)
In-Reply-To: <20050520194220.GA18259@havoc.gtf.org>
Note that I only consider a very few of these items, highlighted below,
to be merge-stoppers. The rest are minor things that can be fixed up at
leisure.
> 8) excessive stack size in bnx2_alloc_bad_rbuf():
> 9) [additional review] DaveM, others: is this correct for all arches?
> 13) [additional review] why is CHECKSUM_UNNECESSARY used when
> cksum==0xffff or cksum==0 ?
> 15) the following loop is just silly. use mdelay or (preferably)
> msleep.
> 19) [additional review] need flush_scheduled_work(), if using work queues?
> 21) need to call bnx2_netif_stop() in bnx2_close()
> 27) isn't 'timer_interval == HZ' too rapid a timer? Does it really need
> to fire every second?
next prev parent reply other threads:[~2005-05-20 20:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-20 17:15 A new driver for Broadcom bcm5706 Michael Chan
2005-05-20 19:42 ` Jeff Garzik
2005-05-20 20:51 ` Jeff Garzik [this message]
2005-05-20 21:07 ` Ben Greear
2005-05-20 21:09 ` Jeff Garzik
2005-05-20 20:17 ` Michael Chan
2005-05-20 21:58 ` Ben Greear
2005-05-20 22:28 ` David S. Miller
2005-05-20 23:04 ` Michael Chan
2005-05-21 4:35 ` David S. Miller
2005-05-21 4:36 ` David S. Miller
2005-05-20 23:30 ` Jeff Garzik
2005-05-20 23:45 ` David S. Miller
2005-05-21 0:01 ` Jeff Garzik
2005-05-20 23:11 ` Michael Chan
2005-05-21 4:28 ` David S. Miller
2005-05-20 21:18 ` Jeff Garzik
2005-05-27 7:41 ` Christoph Hellwig
2005-05-27 15:58 ` Michael Chan
2005-05-27 17:15 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=428E4DE2.1020002@pobox.com \
--to=jgarzik@pobox.com \
--cc=davem@davemloft.net \
--cc=ffan@broadcom.com \
--cc=lusinsky@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.