All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Vinson <rvinson@mvista.com>
To: linuxppc-embedded@ozlabs.org
Subject: [PATCH][PPC32] Fix an Off-By-One Error in arch/ppc/syslib/ipic.c
Date: Fri, 20 May 2005 17:40:09 -0700	[thread overview]
Message-ID: <428E8369.50500@mvista.com> (raw)

Fix an off-by-one error in ipic_init.

There is an off-by-one error in the IPIC code that configures the
external interrupts (Edge or Level Sensitive).

Signed-off-by Randy Vinson <rvinson@mvista.com>

---
commit 0c92b569e09b94a1580cc5bae6efbdd749fec28a
tree 9c1e83adcec1bee0a700888546385444ef5f4000
parent 66e60f92518268f4d2a702a1c4ffbe1caacd6290
author Randy Vinson <rvinson@linuxbox.(none)> Fri, 20 May 2005 15:58:02 -0700
committer Randy Vinson <rvinson@linuxbox.(none)> Fri, 20 May 2005 15:58:02 -0700

arch/ppc/syslib/ipic.c |    2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

Index: arch/ppc/syslib/ipic.c
===================================================================
--- 889a1e2919ac50253be8136a1b0855fde27fcb36/arch/ppc/syslib/ipic.c  (mode:100644)
+++ 9c1e83adcec1bee0a700888546385444ef5f4000/arch/ppc/syslib/ipic.c  (mode:100644)
@@ -479,7 +479,7 @@
    temp = 0;
    for (i = 0 ; i < senses_count ; i++) {
        if ((senses[i] & IRQ_SENSE_MASK) == IRQ_SENSE_EDGE) {
-            temp |= 1 << (16 - i);
+            temp |= 1 << (15 - i);
            if (i != 0)
                irq_desc[i + irq_offset + MPC83xx_IRQ_EXT1 - 1].status = 0;
            else

                 reply	other threads:[~2005-05-21  1:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=428E8369.50500@mvista.com \
    --to=rvinson@mvista.com \
    --cc=linuxppc-embedded@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.