All of lore.kernel.org
 help / color / mirror / Atom feed
From: Love Kumar <love.kumar@amd.com>
To: Andrew Goodbody <andrew.goodbody@linaro.org>, u-boot@lists.denx.de
Cc: Marek Vasut <marex@denx.de>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH] test/py: usb: Fix format string for fstype command
Date: Thu, 6 Feb 2025 10:28:01 +0530	[thread overview]
Message-ID: <428eedd1-b336-4dec-8631-1f4b9c8d8908@amd.com> (raw)
In-Reply-To: <20250205130427.2385292-1-andrew.goodbody@linaro.org>



On 05/02/25 6:34 pm, Andrew Goodbody wrote:
> USB tests on ext partitions can fail with the following output
> 
> test/py/tests/test_usb.py:245: in test_usb_part
>      'fstype usb %d:%d' % i, part_id
> E   TypeError: not enough arguments for format string
> 
> So add brackets around the format string arguments to prevent the
> error.
> 
> Fixes: a730947974e3 ("test/py: usb: Distinguish b/w ext2/ext4 partitions")
> Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>

Reviewed-by: Love Kumar <love.kumar@amd.com>

Regards,
Love Kumar

> ---
> 
>   test/py/tests/test_usb.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/py/tests/test_usb.py b/test/py/tests/test_usb.py
> index e1f203b5cbc..566d73b7c64 100644
> --- a/test/py/tests/test_usb.py
> +++ b/test/py/tests/test_usb.py
> @@ -242,7 +242,7 @@ def test_usb_part(u_boot_console):
>                       elif part_type == '83':
>                           print('ext(2/4) detected')
>                           output = u_boot_console.run_command(
> -                            'fstype usb %d:%d' % i, part_id
> +                            'fstype usb %d:%d' % (i, part_id)
>                           )
>                           if 'ext2' in output:
>                               part_ext2.append(part_id)

  parent reply	other threads:[~2025-02-06  4:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-05 13:04 [PATCH] test/py: usb: Fix format string for fstype command Andrew Goodbody
2025-02-05 15:30 ` Marek Vasut
2025-02-06  4:58 ` Love Kumar [this message]
2025-02-10 20:38 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=428eedd1-b336-4dec-8631-1f4b9c8d8908@amd.com \
    --to=love.kumar@amd.com \
    --cc=andrew.goodbody@linaro.org \
    --cc=marex@denx.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.