From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [PATCH] ioemu breaks build
Date: Sun, 22 May 2005 19:56:08 -0500
Message-ID: <42912A28.3060305@us.ibm.com>
References: <429113F5.3090506@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <429113F5.3090506@us.ibm.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Just a little more info.

The root cause of the problem is that HOST_ARCH is being set to `uname -i`.

On fedora, this produces "i386".  On Gentoo, this produces vendor_id 
from /proc/cpuinfo.

A better fix may be to set HOST_ARCH to i386 explicitly.  Since ioemu 
doesn't build for x86_32 this seems reasonable.

Regards,

Anthony Liguori

Anthony Liguori wrote:

> The following patch fixes the following build failure:
>
> gcc  
> -Wl,-T,/home/xen/builds/200505221736/xen-unstable/tools/ioemu/GenuineIntel.ld 
> -o qemu-dm vl.o exec.o monitor.o osdep.o block.o readline.o pci.o 
> console.o block-cloop.o ide.o ne2000.o pckbd.o vga.o dma.o fdc.o 
> mc146818rtc.o serial.o i8259.o i8254.o pc.o sdl.o libqemu.a  -lm 
> -L../../../dist/install/usr/lib -lxc -lxutil -lz -L/usr/lib 
> -Wl,-rpath,/usr/lib -lSDL -lpthread -lm -ldl -lasound -lX11 -lXext 
> -lvga  -lutil
> /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.4/../../../../i686-pc-linux-gnu/bin/ld: 
> cannot open linker script file 
> /home/xen/builds/200505221736/xen-unstable/tools/ioemu/GenuineIntel.ld: 
> No such file or directory
> collect2: ld returned 1 exit status
> make[5]: *** [qemu-dm] Error 1
> make[5]: Leaving directory 
> `/home/xen/builds/200505221736/xen-unstable/tools/ioemu/target-i386-dm'
> make[4]: *** [all] Error 1
>
> I've confirmed the build for x86_32.  I do not have VMX hardware 
> though so that's all I can do.
>
> Regards,
>
> Anthony Liguori
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>
>------------------------------------------------------------------------
>
>diff -ur xen-unstable-orig/tools/ioemu/target-i386-dm/Makefile xen-unstable/tools/ioemu/target-i386-dm/Makefile
>--- xen-unstable-orig/tools/ioemu/target-i386-dm/Makefile	2005-05-21 22:31:42.000000000 -0500
>+++ xen-unstable/tools/ioemu/target-i386-dm/Makefile	2005-05-22 18:14:49.727960384 -0500
>@@ -300,7 +300,7 @@
> ifdef CONFIG_STATIC
> VL_LDFLAGS+=-static
> endif
>-VL_LDFLAGS+=-Wl,-T,$(SRC_PATH)/$(HOST_ARCH).ld
>+VL_LDFLAGS+=-Wl,-T,$(SRC_PATH)/$(TARGET_ARCH).ld
> ifndef CONFIG_DARWIN
> ifndef CONFIG_WIN32
> VL_LIBS=-lutil
>  
>