From: Jeff Garzik <jgarzik@pobox.com>
To: Michael Chan <mchan@broadcom.com>
Cc: davem@davemloft.net, netdev@oss.sgi.com
Subject: Re: [PATCH 1/6] bnx2: Fix excessive stack usage
Date: Mon, 23 May 2005 21:42:59 -0400 [thread overview]
Message-ID: <429286A3.1060606@pobox.com> (raw)
In-Reply-To: <1116894307.4908.28.camel@rh4>
Michael Chan wrote:
> diff -Nru 10/drivers/net/bnx2.c 11/drivers/net/bnx2.c
> --- 10/drivers/net/bnx2.c 2005-05-23 10:20:02.000000000 -0700
> +++ 11/drivers/net/bnx2.c 2005-05-23 10:20:20.000000000 -0700
> @@ -1138,13 +1138,20 @@
> }
> }
>
> -static void
> +static int
> bnx2_alloc_bad_rbuf(struct bnx2 *bp)
> {
> - u16 good_mbuf[512];
> + u16 *good_mbuf;
> u32 good_mbuf_cnt;
> u32 val;
>
> + good_mbuf = kmalloc(512 * sizeof(u16), GFP_KERNEL);
> + if (good_mbuf == NULL) {
> + printk(KERN_ERR PFX "Failed to allocate memory in "
> + "bnx2_alloc_bad_rbuf\n");
> + return -ENOMEM;
> + }
> +
> REG_WR(bp, BNX2_MISC_ENABLE_SET_BITS,
> BNX2_MISC_ENABLE_SET_BITS_RX_MBUF_ENABLE);
>
> @@ -1178,6 +1185,7 @@
>
> REG_WR_IND(bp, BNX2_RBUF_FW_BUF_FREE, val);
> }
> + return 0;
> }
>
> static void
memleak -- you need to free good_mbuf.
Jeff
next prev parent reply other threads:[~2005-05-24 1:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-23 23:53 [PATCH 0/6] bnx2: Misc fixes Michael Chan
2005-05-24 0:25 ` [PATCH 1/6] bnx2: Fix excessive stack usage Michael Chan
2005-05-24 1:42 ` Jeff Garzik [this message]
2005-05-24 4:29 ` Michael Chan
2005-05-24 5:43 ` Jeff Garzik
2005-05-25 22:18 ` David S. Miller
2005-05-24 0:26 ` [PATCH 2/6] bnx2: Fix rx checksum Michael Chan
2005-05-24 0:27 ` [PATCH 3/6] bnx2: Fix excessive udelay Michael Chan
2005-05-24 0:29 ` [PATCH 4/6] bnx2: Fix bug in bnx2_close Michael Chan
2005-05-24 0:29 ` [PATCH 5/6] bnx2: Add bnx2 prefix and mark static Michael Chan
2005-05-24 0:30 ` [PATCH 6/6] bnx2: Update revision and reldate Michael Chan
2005-05-24 1:48 ` [PATCH 0/6] bnx2: Misc fixes Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=429286A3.1060606@pobox.com \
--to=jgarzik@pobox.com \
--cc=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.