All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Millan <jesse.millan@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] Fix gcc4 warning, def & len may be used uninitialized
Date: Thu, 26 May 2005 23:02:33 +0000	[thread overview]
Message-ID: <42965589.1020405@gmail.com> (raw)
In-Reply-To: <4294CCEE.70907@comcast.net>


From now on, Ill initialize the parameters at the top/start of the
callee, unless it does not make sense to do so.

Thanks for the input.

Arnd Bergmann wrote:
> On Middeweken 25 Mai 2005 21:18, Jesse Millan wrote:
> 
>>Your right, it could go either way. Arnd Bergmann had posted earlier and
>>said that it would be better to make the change in the function itself.
>>I took that advice.
> 
> 
> I think what Mark was suggesting is to initialize the parameters at the
> start of the inner function (asn1_length_decode), which makes perfect
> sense to me, at least in this particular case.
> 
> What you should not do is initialize it in the calling function, because
> then you defeat gcc's ability to warn you about real uninitialized uses
> of the local variables in that function.
> 
> 	Arnd <><
> 

-- 
Jesse Millan
CNS Unix Team
Portland State University
Phone: (503) 725-9151
Mobile: (503) 453-0748
GPG key: www.system-calls.com/gpg.php

grep --recursive --ignore-case 'SHOULD WORK' /usr/src/linux/* | wc
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

      parent reply	other threads:[~2005-05-26 23:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-25 19:07 [KJ] [PATCH] Fix gcc4 warning, def & len may be used uninitialized Mark Hollomon
2005-05-25 19:18 ` Jesse Millan
2005-05-26 23:02 ` Jesse Millan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42965589.1020405@gmail.com \
    --to=jesse.millan@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.