All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: "Markus F.X.J. Oberhumer" <markus@oberhumer.com>
Cc: Linus Torvalds <torvalds@osdl.org>, git@vger.kernel.org
Subject: Re: [PATCH] Fix ptrdiff_t vs. int
Date: Fri, 27 May 2005 10:58:53 -0700	[thread overview]
Message-ID: <42975FDD.9050901@zytor.com> (raw)
In-Reply-To: <42975C1F.8070102@oberhumer.com>

Markus F.X.J. Oberhumer wrote:
> 
> Many thanks. BTW, this is probably completely irrelevant on all 
> real-world machines and calling conventions, but still, lying on the 
> number of arguments in vararg-functions is not my favourite practice.
> 

Bullshit.

Think about the way stdarg works, and you should quickly figure out that 
it is perfectly safe to pass extra arguments.

However, this code can also be rewritten:

	fputs(header, stdout);
	if (diff_output_format == DIFF_FORMAT_MACHINE)
		putchar('\0');

... which is probably faster anyway.

	-hpa

  reply	other threads:[~2005-05-27 17:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-27 13:20 [PATCH] Fix ptrdiff_t vs. int Markus F.X.J. Oberhumer
2005-05-27 13:51 ` Danjel McGougan
2005-05-27 14:02 ` Morten Welinder
2005-05-27 16:25 ` H. Peter Anvin
2005-05-27 17:18 ` Linus Torvalds
2005-05-27 17:25   ` Linus Torvalds
2005-05-27 17:42     ` Markus F.X.J. Oberhumer
2005-05-27 17:58       ` H. Peter Anvin [this message]
2005-05-27 18:13       ` Linus Torvalds
2005-05-27 18:20     ` Junio C Hamano
2005-05-28  4:05       ` [PATCH] Adjust diff-helper to diff-tree -v -z changes Junio C Hamano
2005-05-29 18:31         ` Linus Torvalds
2005-05-29 20:21           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42975FDD.9050901@zytor.com \
    --to=hpa@zytor.com \
    --cc=git@vger.kernel.org \
    --cc=markus@oberhumer.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.