Re: [PATCH dpdk] meson: properly disable docs

[Thomas Monjalon <thomas@monjalon.net>]

22/10/2024 17:49, Bruce Richardson:
> On Tue, Oct 22, 2024 at 05:31:47PM +0200, Robin Jarry wrote:
> > Bruce Richardson, Oct 22, 2024 at 17:25:
> > > No strong objection to this. Just FYI, the reason it is currently done as
> > > it is in the build, is that even if you configure a build without the docs
> > > enabled, you can just build the docs explicitly by doing "ninja -C build
> > > doc". That is so that one can do a test build of the docs without
> > > a) having to reconfigure the whole project
> > > b) not have every build from then on rebuild e.g. the APIs doc if you
> > > change a header.
> > 
> > Oh, I didn't know it was on purpose. I was surprised to see doc related
> > warnings with -Denable_docs=false.
> > 
> > Feel free to disregard this patch if you think it is too drastic.
> > 
> Like I said, I don't have that strong of opinions about it - I just wanted
> to let you and others know that there was *some* (however little) method
> behind the madness of doing things this way.

Let's not change the convenient behaviour.
I reject this patch.

> It is possible to fix the error directly, so that the warning does not
> appear if docs are disabled?

We must fix warnings yes.