From: Keith Moore <keithmo@exmsft.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Trivial module unload problem in 2.6.12-rc5[-mm1]
Date: Sat, 28 May 2005 21:17:48 +0200 [thread overview]
Message-ID: <4298C3DC.5040100@exmsft.com> (raw)
I've found a trivial module unload problem in the 2.6.12-rc5 and (-mm1)
kernels.
net/ipv4/multipath_drr.c can cause an oops soon after unloading. Its
module init routine calls multipath_alg_register() with the incorrect
IP_MP_ALG_RR value, but its module exit routine calls
multipath_alg_deregister() with the *correct* IP_MP_ALG_DRR value.
Easy fix:
--- linux-2.6.12-rc5-mm1/net/ipv4/multipath_drr.c.old 2005-05-28
15:03:24.000000000 +0200
+++ linux-2.6.12-rc5-mm1/net/ipv4/multipath_drr.c 2005-05-28
15:03:31.000000000 +0200
@@ -244,7 +244,7 @@ static int __init drr_init(void)
if (err)
return err;
- err = multipath_alg_register(&drr_ops, IP_MP_ALG_RR);
+ err = multipath_alg_register(&drr_ops, IP_MP_ALG_DRR);
if (err)
goto fail;
Thanks,
KM
reply other threads:[~2005-05-28 19:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4298C3DC.5040100@exmsft.com \
--to=keithmo@exmsft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.