From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:40548 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730110AbeHIBUg (ORCPT ); Wed, 8 Aug 2018 21:20:36 -0400 From: Laurent Pinchart To: Kieran Bingham Cc: mchehab@kernel.org, Rob Herring , Mark Rutland , Hans Verkuil , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Kieran Bingham , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] dt-bindings: media: adv748x: Document secondary addresses Date: Thu, 09 Aug 2018 01:59:29 +0300 Message-ID: <4299631.dFueHHkrC4@avalon> In-Reply-To: <20180808173128.6400-1-kieran.bingham@ideasonboard.com> References: <20180808173128.6400-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Kieran, Thank you for the patch. On Wednesday, 8 August 2018 20:31:28 EEST Kieran Bingham wrote: > The ADV748x supports configurable slave addresses for its I2C pages. > Document the page names, and example for setting each of the pages > excplicitly. > > Signed-off-by: Kieran Bingham > --- > .../devicetree/bindings/media/i2c/adv748x.txt | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/adv748x.txt > b/Documentation/devicetree/bindings/media/i2c/adv748x.txt index > 21ffb5ed8183..9515d8ad0e31 100644 > --- a/Documentation/devicetree/bindings/media/i2c/adv748x.txt > +++ b/Documentation/devicetree/bindings/media/i2c/adv748x.txt > @@ -18,6 +18,11 @@ Optional Properties: > "intrq3". All interrupts are optional. The "intrq3" interrupt > is only available on the adv7481 > - interrupts: Specify the interrupt lines for the ADV748x > + - reg-names : Names of maps with programmable addresses. > + It can contain any map needed a non-default address. s/can contain any map needed/shall contain all maps needing/ > + Possible map names are: > + "main", "dpll", "cp", "hdmi", "edid", "repeater", > + "infoframe", "cbus", "cec", "sdp", "txa", "txb" Should you also update the description of the reg property, possibly with the same text as the adv7604 bindings ? > The device node must contain one 'port' child node per device input and > output port, in accordance with the video interface bindings defined in > @@ -47,7 +52,10 @@ Example: > > video-receiver@70 { > compatible = "adi,adv7482"; > - reg = <0x70>; > + reg = <0x70 0x71 0x72 0x73 0x74 0x75 > + 0x60 0x61 0x62 0x63 0x64 0x65>; > + reg-names = "main", "dpll", "cp", "hdmi", "edid", "repeater", > + "infoframe", "cbus", "cec", "sdp", "txa", "txb"; > > #address-cells = <1>; > #size-cells = <0>; -- Regards, Laurent Pinchart