From: James Courtier-Dutton <James@superbug.co.uk>
To: Lee Revell <rlrevell@joe-job.com>
Cc: alsa-devel <alsa-devel@lists.sourceforge.net>
Subject: Re: [PATCH] emu10k1 cleanups
Date: Sun, 29 May 2005 11:07:55 +0100 [thread overview]
Message-ID: <4299947B.30202@superbug.co.uk> (raw)
In-Reply-To: <1117339570.19303.4.camel@mindpipe>
Lee Revell wrote:
> I hacked this up quickly, please review.
>
> Some of these should probably be macros, like
>
> IS_AUDIGY2(emu)
>
> for
>
> emu->card_capabilities->ca0108_chip || emu->card_capabilities->ca0151_chip
>
> etc.
>
> This will break binary compatibility as some redundant struct members have been removed.
>
> Lee
>
Sorry, I can't accept this patch.
Different chips have different capabilities, and the ca0108(Audigy 2
Value) certainly does not have a ca0151 (P16V) chip.
The ca0102 is the DSP chip on Audigy 2 cards (and possibly Audigy 1, I
don't know for sure).
emu10k2 is to indicate that the card has all the same features of the
DSP chip found on Audigy 1 and Audigy 2 and Audigy 2 Value cards.
So, the information is not redundent.
-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
next prev parent reply other threads:[~2005-05-29 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-29 4:06 [PATCH] emu10k1 cleanups Lee Revell
2005-05-29 10:07 ` James Courtier-Dutton [this message]
2005-05-29 20:18 ` Lee Revell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4299947B.30202@superbug.co.uk \
--to=james@superbug.co.uk \
--cc=alsa-devel@lists.sourceforge.net \
--cc=rlrevell@joe-job.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.