From: Jesse Millan <jesse.millan@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] Fix misleading gcc4 warning,
Date: Mon, 30 May 2005 00:14:24 +0000 [thread overview]
Message-ID: <429A5AE0.6070001@gmail.com> (raw)
In-Reply-To: <42966B18.6020802@cs.pdx.edu>
[jessem@sc]$ /usr/local/gcc4/bin/gcc --version
gcc (GCC) 4.0.0
[jessem@sc]$ uname -a
Linux system-calls 2.6.8.1-20mdk #1 Wed Nov 3 04:24:32 EST 2004 x86_64
AMD Athlon(tm) 64 Processor 3000+ unknown GNU/Linux
Adrian Bunk wrote:
> On Thu, May 26, 2005 at 08:52:14PM -0700, randy_dunlap wrote:
>
>>On Thu, 26 May 2005 17:34:32 -0700 Jesse Millan wrote:
>>
>>|
>>| This warning is a false alarm.
>>|
>>| This patch eliminates the warning that addr may be used uninitialized in
>>| the function it87_find. addr is not used uninitialized.
>>
>>It's 'address', not 'addr'.
>>
>>
>>--- linux-2.6.12-rc5/drivers/i2c/chips/it87.c~ 2005-05-26 16:35:24.852065714 -0700
>>+++ linux-2.6.12-rc5/drivers/i2c/chips/it87.c 2005-05-26 17:20:31.311097793 -0700
>>@@ -718,6 +718,10 @@ static int it87_find(int *address)
>> {
>> int err = -ENODEV;
>>
>>+ /* Suppress misleading GCC warning:
>>+ * 'address' may be used uninitialized in this function. */
>>+ *address = 0;
>>+
>>
>>Lose the comments. Just use patch comments (saved in the SCM) for such
>>comments, not source files.
>>
>>If I knew enough about compilers, I would just blame this on the compiler
>>and not fix it in the Linux source code (which just covers up the
>>compiler bug IMO).
>
>
> I'm not seeing this warning.
>
> Which gcc version are you using?
>
>
>>~Randy
>
>
> cu
> Adrian
>
--
Jesse Millan
CNS Unix Team
Portland State University
Phone: (503) 725-9151
Mobile: (503) 453-0748
GPG key: www.system-calls.com/gpg.php
grep --recursive --ignore-case 'SHOULD WORK' /usr/src/linux/* | wc
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2005-05-30 0:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-27 0:34 [KJ] [PATCH] Fix misleading gcc4 warning, Jesse Millan
2005-05-27 3:52 ` [KJ] [PATCH] Fix misleading gcc4 warning, addr may be used randy_dunlap
2005-05-30 0:03 ` [KJ] [PATCH] Fix misleading gcc4 warning, Adrian Bunk
2005-05-30 0:14 ` Jesse Millan [this message]
2005-05-30 1:59 ` Adrian Bunk
2005-05-30 4:56 ` Jesse Millan
2005-05-30 8:24 ` Arnd Bergmann
2005-06-01 21:35 ` Jesse Millan
2005-06-03 18:52 ` Jesse Millan
2005-06-16 22:16 ` [KJ] [PATCH] Fix misleading gcc4 warning: (160) offset and block Jesse Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=429A5AE0.6070001@gmail.com \
--to=jesse.millan@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.