From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nivedita Singhvi <niv@us.ibm.com>
Subject: [PATCH] skb_copy_bits() can return err
Date: Wed, 01 Jun 2005 16:01:56 -0700
Message-ID: <429E3E64.90609@us.ibm.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="------------060804020306030906030300"
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

This is a multi-part message in MIME format.
--------------060804020306030906030300
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

skb_copy_bits() can return an err, so have netif_be_start_xmit()
crash informatively..

thanks,
Nivedita



--------------060804020306030906030300
Content-Type: text/plain;
 name="skb_cb.triv.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="skb_cb.triv.patch"

diff -urN xen-unstable-0601/linux-2.6.11-xen-sparse/drivers/xen/netback/netback.c niv-unstable-0601/linux-2.6.11-xen-sparse/drivers/xen/netback/netback.c
--- xen-unstable-0601/linux-2.6.11-xen-sparse/drivers/xen/netback/netback.c	2005-05-31 20:12:37.000000000 -0700
+++ niv-unstable-0601/linux-2.6.11-xen-sparse/drivers/xen/netback/netback.c	2005-06-01 15:20:52.954245318 -0700
@@ -153,7 +153,9 @@
             goto drop;
         skb_reserve(nskb, hlen);
         __skb_put(nskb, skb->len);
-        (void)skb_copy_bits(skb, -hlen, nskb->data - hlen, skb->len + hlen);
+        if (skb_copy_bits(skb, -hlen, nskb->data - hlen, skb->len + hlen)) {
+		BUG();
+	}
         nskb->dev = skb->dev;
         nskb->proto_csum_valid = skb->proto_csum_valid;
         dev_kfree_skb(skb);

--------------060804020306030906030300
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--------------060804020306030906030300--