Re: sata_sil problem / oops

[Jeff Garzik <jgarzik@pobox.com>]

Jens Axboe wrote:
> Seems that is so, from looking at the driver. If I were to guess at a
> fix for this, it would be as follows.
> 
> diff --git a/drivers/scsi/sata_sil.c b/drivers/scsi/sata_sil.c
> --- a/drivers/scsi/sata_sil.c
> +++ b/drivers/scsi/sata_sil.c
> @@ -432,7 +432,13 @@ static int sil_init_one (struct pci_dev 
>  		writeb(cls, mmio_base + SIL_FIFO_R0);
>  		writeb(cls, mmio_base + SIL_FIFO_W0);
>  		writeb(cls, mmio_base + SIL_FIFO_R1);
> -		writeb(cls, mmio_base + SIL_FIFO_W2);
> +		writeb(cls, mmio_base + SIL_FIFO_W1);
> +		if (ent->driver_data == sil_3114) {
> +			writeb(cls, mmio_base + SIL_FIFO_R2);
> +			writeb(cls, mmio_base + SIL_FIFO_W2);
> +			writeb(cls, mmio_base + SIL_FIFO_R3);
> +			writeb(cls, mmio_base + SIL_FIFO_W3);
> +		}


This definitely looks like a needed fix to me.

Can someone confirm that this fixes the reported problem?

	Jeff