From: Dan Carpenter <dan.carpenter@linaro.org>
To: Dima Volkovsk <s0ldw3ll@gmail.com>
Cc: marvin24@gmx.de, gregkh@linuxfoundation.org,
ac100@lists.launchpad.net, linux-tegra@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: nvec: Fix pm_power_off reset condition in tegra_nvec_remove
Date: Wed, 12 Feb 2025 10:33:13 +0300 [thread overview]
Message-ID: <429e6aa2-b195-4624-a609-e1445dcbd150@stanley.mountain> (raw)
In-Reply-To: <20250209201752.66313-1-s0ldw3ll@gmail.com>
On Sun, Feb 09, 2025 at 09:16:48PM +0100, Dima Volkovsk wrote:
> In the current implementation of tegra_nvec_remove, the pm_power_off handler
> is set to NULL without checking if it is actually set to nvec_power_off. This
> change ensures that pm_power_off is only reset if it was previously set to
> nvec_power_off, preventing unintended side effects when removing the device.
>
> Signed-off-by: Dima Volkovsk <s0ldw3ll@gmail.com>
What everyone else said and also you forgot to add a Fixes tag.
regards,
dan carpenter
prev parent reply other threads:[~2025-02-12 7:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-09 20:16 [PATCH] Staging: nvec: Fix pm_power_off reset condition in tegra_nvec_remove Dima Volkovsk
2025-02-10 6:10 ` Greg KH
2025-02-10 12:31 ` kernel test robot
2025-02-10 14:08 ` kernel test robot
2025-02-12 7:33 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=429e6aa2-b195-4624-a609-e1445dcbd150@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=ac100@lists.launchpad.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=s0ldw3ll@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.