All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sylvain Munaut <tnt@246tNt.com>
To: Jon Loeliger <jdl@freescale.com>
Cc: "linuxppc-embedded@ozlabs.org" <linuxppc-embedded@ozlabs.org>
Subject: Re: bd_t Cleaning: Interface Part
Date: Sat, 04 Jun 2005 20:13:25 +0200	[thread overview]
Message-ID: <42A1EF45.9030400@246tNt.com> (raw)
In-Reply-To: <1117221259.26114.91.camel@cashmere.sps.mot.com>

Jon Loeliger wrote:
> On Thu, 2005-05-26 at 18:08, Kumar Gala wrote:
> 
>>Jon,
>>
>>Can you break the patch up into a few pieces, it will be easier to 
>>review that way.  Here are the following pieces that make sense to me:
>>
>>0. New firmware interface (fw_bdt*, Kconfig, ...)
>>1. board code changes (everything in arch/ppc/platforms/*)
>>2. driver changes (things in *_io, ide, net, serial dirs -- try to give 
>>a better list below)
>>3. System changes (files in arch/ppc/syslib and include/asm-ppc)

FWIW, tested on 5200 and works fine. Looks good to me.

Just a remark : I see a CONFIG_FW_OF option that activates
fw_of.o but there is no fw_of.c and I don't see what the flattened
OF tree does in this set of patch ?



	Sylvain

  parent reply	other threads:[~2005-06-04 18:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-19  6:41 OF flat device tree for ppc32 Jakob Viketoft
2005-05-19 15:37 ` Jon Loeliger
2005-05-19 18:04   ` Dan Malek
2005-05-20 16:40 ` Jon Loeliger
2005-05-26 23:08   ` Kumar Gala
2005-05-27 19:14     ` bd_t Cleaning: Interface Part Jon Loeliger
2005-05-30 10:13       ` Clemens Koller
2005-05-31 14:59         ` Jon Loeliger
2005-06-04 18:13       ` Sylvain Munaut [this message]
2005-05-27 19:16     ` bd_t Cleaning: Board Changes Jon Loeliger
2005-06-01 18:10       ` Mark A. Greer
2005-06-01 18:52         ` Kumar Gala
2005-08-29 23:46         ` Mark A. Greer
2005-05-27 19:18     ` bd_t Cleaning: Driver Bits Jon Loeliger
2005-05-27 19:20     ` bd_t Cleaning: System Parts Jon Loeliger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42A1EF45.9030400@246tNt.com \
    --to=tnt@246tnt.com \
    --cc=jdl@freescale.com \
    --cc=linuxppc-embedded@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.