All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Support for read-only MMC cards
Date: Sat, 04 Jun 2005 22:05:00 +0200	[thread overview]
Message-ID: <42A2096C.9010108@drzeus.cx> (raw)
In-Reply-To: <20050604205810.A23449@flint.arm.linux.org.uk>

Russell King wrote:

>
>I'd prefer this to be:
>
>	printk(KERN_INFO "%s: %s %s %dKiB%s\n",
> 		md->disk->disk_name, mmc_card_id(card), mmc_card_name(card),
> 		(card->csd.capacity << card->csd.read_blkbits) / 1024,
>		card->csd.cmdclass & CCC_BLOCK_WRITE ? "" : " (ro)");
>
>  
>

I'd rather not since the SD patches have a similar test but on a
different condition. It makes the [SD] patch a bit easier to follow when
trying to determine what it does. Since it doesn't seem to be getting
included anytime soon I'm trying to do what I can to keep it maintainable.

Rgds
Pierre


  reply	other threads:[~2005-06-04 20:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-04 19:54 [PATCH] Support for read-only MMC cards Pierre Ossman
2005-06-04 19:58 ` Russell King
2005-06-04 20:05   ` Pierre Ossman [this message]
2005-06-04 20:07     ` Russell King
2005-06-04 20:14       ` Pierre Ossman
2005-06-04 20:16         ` Russell King
2005-06-04 20:24           ` Pierre Ossman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42A2096C.9010108@drzeus.cx \
    --to=drzeus-list@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+lkml@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.