All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Git Mailing List <git@vger.kernel.org>
Subject: git bug?
Date: Thu, 09 Jun 2005 02:54:37 -0400	[thread overview]
Message-ID: <42A7E7AD.5030108@pobox.com> (raw)


Just upgraded to the latest git, pulled the latest Linux kernel tree, 
and made a local modification.  Here is the strange git-diff-cache output:

> [jgarzik@pretzel libata-dev]$ git-diff-cache -p HEAD 
> diff --git a/arch/arm/mm/minicache.c b/arch/arm/mm/minicache.c
> deleted file mode 100644
> diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
> --- a/drivers/scsi/libata-core.c
> +++ b/drivers/scsi/libata-core.c
> @@ -3059,8 +3059,6 @@ static void __ata_qc_complete(struct ata
>         struct ata_port *ap = qc->ap;
>         unsigned int tag, do_clear = 0;
>  
> -       WARN_ON(!assert_spin_locked(&ap->host_set->lock));
> -
>         if (likely(qc->flags & ATA_QCFLAG_ACTIVE)) {
>                 assert(ap->queue_depth);
>                 ap->queue_depth--;

The libata-core part is correct, the arch/arm/mm part is not.

I pulled using unmodified, upstream git scripts.  No sugar added. 
Here's what the repo looks like:

> [jgarzik@pretzel libata-dev]$ git-rev-list --pretty HEAD ^master | git-shortlog 
> Jeff Garzik:
>   Merge /spare/repo/linux-2.6/
>   Automatic merge of /spare/repo/linux-2.6/.git branch HEAD
> 
> Jens Axboe:
>   libata: fix spinlock bug introduced by NCQ code
>   libata: ncq support update
>   libata-scsi: better placement of cmd completion on err
>   SATA NCQ support

It's mirroring to kernel.org right now, at 
rsync.kernel.org://...jgarzik/libata-dev.git if somebody wants to poke 
at it.  Top of tree is d032ec9048ff82a704b96b93cfd6f2e8e3a06b19 (when 
fully uploaded and mirrored).

	Jeff




             reply	other threads:[~2005-06-09  6:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-09  6:54 Jeff Garzik [this message]
2005-06-09  7:39 ` git bug? Jeff Garzik
     [not found] ` <7vy89kq96o.fsf@assigned-by-dhcp.cox.net>
2005-06-09  7:55   ` Junio C Hamano
2005-06-09  8:01     ` Jeff Garzik
2005-06-09  8:15       ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2020-09-26 17:57 PANEL Christian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42A7E7AD.5030108@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.