From: Steven Scholz <steven.scholz@imc-berlin.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] byteorder of image_header_t members?
Date: Fri, 10 Jun 2005 13:51:40 +0200 [thread overview]
Message-ID: <42A97ECC.5030708@imc-berlin.de> (raw)
Hi there,
if uint32_t members of image_header_t are stored in network byteorder, then
all references of these members should use ntohl(), right?
So should we fix this for instance:
#~> grep "\->ih_magic" *
cmd_autoscript.c: if (ntohl(hdr->ih_magic) != IH_MAGIC) {
cmd_bootm.c: if (ntohl(hdr->ih_magic) != IH_MAGIC) {
>>> cmd_bootm.c: if (hdr->ih_magic != IH_MAGIC) { <<<
cmd_bootm.c: if (ntohl(hdr->ih_magic) != IH_MAGIC) {
cmd_bootm.c: (ntohl(hdr->ih_magic) != IH_MAGIC))
>>> cmd_doc.c: if (hdr->ih_magic == IH_MAGIC) { <<<
>>> cmd_fdc.c: if (hdr->ih_magic != IH_MAGIC) { <<<
cmd_fpga.c: if (ntohl(hdr->ih_magic) != IH_MAGIC) {
cmd_ide.c: if (ntohl(hdr->ih_magic) != IH_MAGIC) {
cmd_nand.c: if (ntohl(hdr->ih_magic) == IH_MAGIC) {
cmd_scsi.c: if (ntohl(hdr->ih_magic) == IH_MAGIC) {
cmd_usb.c: if (ntohl(hdr->ih_magic) != IH_MAGIC) {
--
Steven
next reply other threads:[~2005-06-10 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-10 11:51 Steven Scholz [this message]
2005-06-10 14:17 ` [U-Boot-Users] byteorder of image_header_t members? Wolfgang Denk
2005-06-10 15:05 ` Steven Scholz
2005-11-22 9:34 ` Steven Scholz
2006-03-12 1:00 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42A97ECC.5030708@imc-berlin.de \
--to=steven.scholz@imc-berlin.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.