[IPTABLES PATCH] chain name should not start with '!'

[IPTABLES PATCH] chain name should not start with '!'

[Yasuyuki KOZAKAI]

[-- Attachment #1: Type: Text/Plain, Size: 217 bytes --]


Hi,

This patch fixes the bug allows to create the chain with name "!".

Regards,

-----------------------------------------------------------------
Yasuyuki Kozakai @ USAGI Project <yasuyuki.kozakai@toshiba.co.jp>


[-- Attachment #2: iptables.patch --]
[-- Type: Text/Plain, Size: 533 bytes --]

Index: iptables.c
===================================================================
--- iptables.c	(revision 3951)
+++ iptables.c	(working copy)
@@ -1925,10 +1925,10 @@
 			break;
 
 		case 'N':
-			if (optarg && *optarg == '-')
+			if (optarg && (*optarg == '-' || *optarg == '!'))
 				exit_error(PARAMETER_PROBLEM,
 					   "chain name not allowed to start "
-					   "with `-'\n");
+					   "with `%c'\n", *optarg);
 			if (find_target(optarg, TRY_LOAD))
 				exit_error(PARAMETER_PROBLEM,
 					   "chain name may not clash "

Re: [IPTABLES PATCH] chain name should not start with '!'

[Pablo Neira]

Hi Yasuyuki,

Yasuyuki KOZAKAI wrote:
> This patch fixes the bug allows to create the chain with name "!".
> 
> Regards,
> 
> -----------------------------------------------------------------
> Yasuyuki Kozakai @ USAGI Project <yasuyuki.kozakai@toshiba.co.jp>
> 
> 
> ------------------------------------------------------------------------
> 
> Index: iptables.c
> ===================================================================
> --- iptables.c	(revision 3951)
> +++ iptables.c	(working copy)

please, could you send the same fix for ip6tables.c? it's got the same 
problem.

Thanks,
Pablo

Re: [IPTABLES PATCH] chain name should not start with '!'

[Yasuyuki KOZAKAI]

[-- Attachment #1: Type: Text/Plain, Size: 880 bytes --]


Good point. Here you are,

-----------------------------------------------------------------
Yasuyuki Kozakai @ USAGI Project <yasuyuki.kozakai@toshiba.co.jp>

From: Pablo Neira <pablo@eurodev.net>
Date: Fri, 03 Jun 2005 10:33:20 +0200

> Hi Yasuyuki,
> 
> Yasuyuki KOZAKAI wrote:
> > This patch fixes the bug allows to create the chain with name "!".
> > 
> > Regards,
> > 
> > -----------------------------------------------------------------
> > Yasuyuki Kozakai @ USAGI Project <yasuyuki.kozakai@toshiba.co.jp>
> > 
> > 
> > ------------------------------------------------------------------------
> > 
> > Index: iptables.c
> > ===================================================================
> > --- iptables.c	(revision 3951)
> > +++ iptables.c	(working copy)
> 
> please, could you send the same fix for ip6tables.c? it's got the same 
> problem.
> 
> Thanks,
> Pablo

[-- Attachment #2: ip6tables.patch --]
[-- Type: Text/Plain, Size: 536 bytes --]

Index: ip6tables.c
===================================================================
--- ip6tables.c	(revision 3951)
+++ ip6tables.c	(working copy)
@@ -1822,10 +1822,10 @@
 			break;
 
 		case 'N':
-			if (optarg && *optarg == '-')
+			if (optarg && (*optarg == '-' || *optarg == '!'))
 				exit_error(PARAMETER_PROBLEM,
 					   "chain name not allowed to start "
-					   "with `-'\n");
+					   "with `%c'\n", *optarg);
 			if (find_target(optarg, TRY_LOAD))
 				exit_error(PARAMETER_PROBLEM,
 					   "chain name may not clash "

Re: [IPTABLES PATCH] chain name should not start with '!'

[Patrick McHardy]

Yasuyuki KOZAKAI wrote:
> This patch fixes the bug allows to create the chain with name "!".

Is there a technical reason for this or is it just "cleanup"?

Regards
Patrick

Re: [IPTABLES PATCH] chain name should not start with '!'

[Yasuyuki KOZAKAI]

From: Patrick McHardy <kaber@trash.net>
Date: Sat, 11 Jun 2005 17:10:47 +0200

> > This patch fixes the bug allows to create the chain with name "!".
>
> Is there a technical reason for this or is it just "cleanup"?

-F, -X, -L, -Z cannot take chain names which have prefix "!".

Of cause we can fix processing of their commands, but changing -N is
the easiest way and I think it's better to avoid to use confusing chain name.

Regards,

-----------------------------------------------------------------
Yasuyuki Kozakai @ USAGI Project <yasuyuki.kozakai@toshiba.co.jp>

Re: [IPTABLES PATCH] chain name should not start with '!'

[Patrick McHardy]

Yasuyuki KOZAKAI wrote:
> From: Patrick McHardy <kaber@trash.net>
> Date: Sat, 11 Jun 2005 17:10:47 +0200
> 
> 
>>>This patch fixes the bug allows to create the chain with name "!".
>>
>>Is there a technical reason for this or is it just "cleanup"?
> 
> 
> -F, -X, -L, -Z cannot take chain names which have prefix "!".
> 
> Of cause we can fix processing of their commands, but changing -N is
> the easiest way and I think it's better to avoid to use confusing chain name.

Thanks for the explanation, I've applied your patch.

Regards
Patrick