From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@davemloft.net>
Cc: Netfilter Development Mailinglist <netfilter-devel@lists.netfilter.org>
Subject: [NETFILTER]: Advance seq-file position in exp_next_seq()
Date: Tue, 14 Jun 2005 02:56:37 +0200 [thread overview]
Message-ID: <42AE2B45.7080106@trash.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 325 bytes --]
Hi Dave,
a small fix for 2.6.12 if still possible: exp_next_seq() (used for
/proc/net/ip_conntracK_expect) doesn't advance the seq-file position.
I haven't tracked exactly why, but this makes the seq-file API show
(n+1)*(n/2) entries, with the first one showed n times, the second
one n-1 times, and so on.
Regards
Patrick
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 876 bytes --]
[NETFILTER]: Advance seq-file position in exp_next_seq()
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
commit 5cc89cae827217a8183d4eb1165cc32f804518fa
tree 7284df19ea5b31f63777407cec1adfd703fa7958
parent f268bb805a9777d5c82c7c1cb683b476d65f0c1b
author Patrick McHardy <kaber@trash.net> Sat, 11 Jun 2005 19:21:28 +0200
committer Patrick McHardy <kaber@trash.net> Sat, 11 Jun 2005 19:21:28 +0200
net/ipv4/netfilter/ip_conntrack_standalone.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/ipv4/netfilter/ip_conntrack_standalone.c b/net/ipv4/netfilter/ip_conntrack_standalone.c
--- a/net/ipv4/netfilter/ip_conntrack_standalone.c
+++ b/net/ipv4/netfilter/ip_conntrack_standalone.c
@@ -256,6 +256,7 @@ static void *exp_seq_next(struct seq_fil
{
struct list_head *e = v;
+ ++*pos;
e = e->next;
if (e == &ip_conntrack_expect_list)
next reply other threads:[~2005-06-14 0:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-14 0:56 Patrick McHardy [this message]
2005-06-14 1:28 ` [NETFILTER]: Advance seq-file position in exp_next_seq() David S. Miller
[not found] <200506140159.j5E1xRb7019657@hera.kernel.org>
2005-06-15 20:47 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42AE2B45.7080106@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.