From: Tolunay Orkun <listmember@orkun.us>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] soft_i2c/i2c_probe(): Perform reads instead of writes
Date: Tue, 14 Jun 2005 16:34:38 -0500 [thread overview]
Message-ID: <42AF4D6E.8050208@orkun.us> (raw)
In-Reply-To: <87hdg5c5w8.fsf@p4.48ers.dk>
Peter Korsgaard wrote:
>>>>>>"Tolunay" == Tolunay Orkun <listmember@orkun.us> writes:
>>>>>>
>>>>>>
>
>Hi, and sorry for the slow response!
>
> Tolunay> Peter, I believe the implementation was correct but the
> Tolunay> comment was wrong. It should be a write transaction with
> Tolunay> just address byte. After the address byte is transmitted the
> Tolunay> I2C slave will acknowledge (if present) and we finish the
> Tolunay> transaction by generating the stop condition. i.e. fake
> Tolunay> write.
>
>Why write? Wouldn't a zero byte read transaction be safer?
>
>
>
I have read somewhere (that I cannot find now), that some device would
lock up on 0-byte read vs 0-byte write. Since the current code is
working as it is unless there is demonstrable problem with it, I would
fix the comment only.
next prev parent reply other threads:[~2005-06-14 21:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-26 20:06 [U-Boot-Users] [PATCH] soft_i2c/i2c_probe(): Perform reads instead of writes Peter Korsgaard
2005-05-26 22:35 ` Tolunay Orkun
2005-06-11 14:41 ` Peter Korsgaard
2005-06-14 21:34 ` Tolunay Orkun [this message]
2005-06-15 3:16 ` Eugene Surovegin
2005-06-15 6:25 ` Peter Korsgaard
2006-03-12 0:31 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42AF4D6E.8050208@orkun.us \
--to=listmember@orkun.us \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.