From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Wray <mike.wray@hp.com>
Subject: Re: VMX device models not getting created anymore?
Date: Wed, 15 Jun 2005 15:30:14 +0100
Message-ID: <42B03B76.7010701@hp.com>
References: <A95E2296287EAD4EB592B5DEEFCE0E9D2821A6@liverpoolst.ad.cl.cam.ac.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <A95E2296287EAD4EB592B5DEEFCE0E9D2821A6@liverpoolst.ad.cl.cam.ac.uk>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>
Cc: Arun Sharma <arun.sharma@intel.com>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Ian Pratt wrote:
>  > http://xen.bkbits.net:8080/xeno-unstable.bk/cset@42a47555156iG
> 
>>oOjUyZtvbuMFZHXkg
>>
>>seems to have removed the call to creating device models.
>>
>>@@ -773,43 +680,6 @@
>>                  ctrl.initController(reboot=True)
>>          else:
>>              self.create_configured_devices()
>>-        if self.is_vmx:
>>-            self.create_vmx_model()
>>
>>I didn't see equivalent code getting added anywhere else.

The code got moved into createDeviceModel in VmxImageHandler
in image.py, but it looks like the call to createDeviceModel got
lost. It should go at the end of create_devices in XendDomainInfo:

     def create_devices(self):
         """Create the devices for a vm.

         @raise: VmError for invalid devices
         """
         if self.rebooting():
             for ctrl in self.getDeviceControllers():
                 ctrl.initController(reboot=True)
         else:
             self.create_configured_devices()
         self.image.createDeviceModel()
> 
> 
> Yep, I just sync'ed my VT tree up to the head to get a couple of your
> fixes, and inherited this breakage as well. There's been loads of
> changes to xend to move its database over to xenstore, but I don't think
> its going to be hard to fix up. 
> 
> I'm not going to get a chance to look at it before Monday evening
> though.
> 
> Best,
> Ian
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>