From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] update raw patch in POM Date: Wed, 22 Jun 2005 05:55:45 +0200 Message-ID: <42B8E141.1080902@trash.net> References: <42A6AB19.2040106@tac.ch> <42A6E685.3060408@eurodev.net> <42AEF774.8060300@tac.ch> <42B67BEC.1090105@tac.ch> <20050621003441.GI8335@postel.suug.ch> <42B76474.8080209@eurodev.net> <20050621111328.GK8335@postel.suug.ch> <42B81D75.8090205@trash.net> <20050621215027.GP8335@postel.suug.ch> <42B8B181.4020607@trash.net> <20050622005243.GQ8335@postel.suug.ch> <42B8DA09.9080406@eurodev.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: Netfilter Developers , Roberto Nibali Return-path: To: Pablo Neira In-Reply-To: <42B8DA09.9080406@eurodev.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org Pablo Neira wrote: >> if ((((long) nfct) & 0xf8000000) && atomic_read(&nfct->master->use) <= 1) >> BUG(); > > > I don't consider reliable such BUG() triggered since I see this as a > tricky race condition. AFAICS, the skbuff still enqueued holds a pointer > to an invalid address that doesn't store ip_conntrack_untracked anymore, > instead it points to something different, say the .bss section of > another module reloaded which isn't the ip_conntrack module. Roberto's > recipe requires module removal and reload in a very short space of time > and I can't assure that those modules are installed and removed in the > same order. I agree, let's track down the untracked-missing-references first, then see if any problems remain. Regards Patrick