From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <aliguori@us.ibm.com>
Subject: [RFC] Cleaning up SCM debug
Date: Wed, 22 Jun 2005 22:20:12 -0500
Message-ID: <42BA2A6C.5000004@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel <xen-devel@lists.xensource.com>, xense-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Hi,

public/acm.h defines both an ACM_DEBUG flag and a printkd function that, 
if ACM_DEBUG is defined will convert to a printk.  public/acm.h is 
included by userspace applications where printk isn't necessarily 
meaningful.  Furthermore, it appears ACM_DEBUG is only used within Xen 
anyway so making it apart of the public headers doesn't make much sense.

Therefore, I'd like to move ACM_DEBUG and printkd into acm/acm_core.h.  
While at it, it seems like a good idea to change the printkd into either 
one of the existing Xen debug macros or to get rid of it altogether.

I wanted to check first to see if there was an emerging standard macro 
(a quick glance shows printk, DPRINTK, PRINT, and I'm sure there are at 
least a few more).  Recommendations are appreciated.

Regards,

Anthony Liguori