From: Felipe W Damasio <felipewd@terra.com.br>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] [RESEND] Audit return code : drivers/char/applicom.c
Date: Thu, 23 Jun 2005 07:40:16 +0000 [thread overview]
Message-ID: <42BA6760.6080004@terra.com.br> (raw)
In-Reply-To: <20050622075313.GE5054@rhum.iomeda.fr>
Hi Chistophe,
Christophe Lucas wrote:
>+out:
>+ for (i = 0 ; i < MAX_BOARD ; i++) {
>+ if (apbs[i].RamIO)
>+ continue;
>
>
I don't get this. Isn't it supposed to be:
if (!apbs[i].RamIO)
?
If you pass apps[i].RamIO to iounmap only when it's set to NULL
you'll always get a "__iounmap: bad address", right?
Cheers,
Felipe Damasio
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2005-06-23 7:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-22 7:53 [KJ] [PATCH] [RESEND] Audit return code : drivers/char/applicom.c Christophe Lucas
2005-06-22 7:56 ` [KJ] [PATCH] [RESEND] Audit return code : drivers/char/lcd.c Christophe Lucas
2005-06-22 15:49 ` randy_dunlap
2005-06-22 16:22 ` [KJ] [PATCH] [RESEND] Audit return code : drivers/char/applicom.c randy_dunlap
2005-06-22 16:25 ` [KJ] [PATCH] [RESEND] Audit return code : drivers/char/lcd.c randy_dunlap
2005-06-23 7:17 ` [KJ] [PATCH] [RESEND] Audit return code : drivers/char/applicom.c Christophe Lucas
2005-06-23 7:18 ` [KJ] [PATCH] [RESEND] Audit return code : drivers/char/lcd.c Christophe Lucas
2005-06-23 7:40 ` Felipe W Damasio [this message]
2005-06-23 8:46 ` [KJ] [PATCH] [RESEND] Audit return code : drivers/char/applicom.c Christophe Lucas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42BA6760.6080004@terra.com.br \
--to=felipewd@terra.com.br \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.