From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arun Sharma Subject: Re: [PATCH] Fix vnc-dryrun option interaction Date: Thu, 23 Jun 2005 09:57:32 -0700 Message-ID: <42BAE9FC.2030103@intel.com> References: <670517d5e836a3caaa16706e6fb84145@cl.cam.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <670517d5e836a3caaa16706e6fb84145@cl.cam.ac.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: George Washington Dunlap III , xen-devel List List-Id: xen-devel@lists.xenproject.org Keir Fraser wrote: > On 23 Jun 2005, at 15:23, George Washington Dunlap III wrote: > >> A patch that was applied yesterday tried to turn the vnc option off if >> dryrun was set. Unfortunately, the way it was actually coded turned >> vnc ON if dryrun was not set! I think this patch should fix it >> (someone who actually uses vnc & dryrun should test it, though). >> >> -George > > > That patch was originally from Arun Sharma at Intel. I've cc'ed him. Please apply this patch. It fixes two problems: - vnc shouldn't be turned on by default (I didn't spot it because I usually have VNC on) - If it's a boolean, its stringified version seen by xend would be "True" or "False". An integer is easier to parse in xend. A patch that I have in my queue expects it to be an integer. -Arun