From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arun Sharma <arun.sharma@intel.com>
Subject: Re: [PATCH] Fix vnc-dryrun option interaction
Date: Thu, 23 Jun 2005 13:30:05 -0700
Message-ID: <42BB1BCD.8070809@intel.com>
References: <Pine.LNX.4.60.0506231018540.4707@stclair.eecs.umich.edu>
	<670517d5e836a3caaa16706e6fb84145@cl.cam.ac.uk>
	<42BAE9FC.2030103@intel.com>
	<e4f3c09a3f981e2c47be9a0d9d60163c@cl.cam.ac.uk>
	<42BB1734.80903@intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="------------070105050203000903070900"
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <42BB1734.80903@intel.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: George Washington Dunlap III <dunlapg@umich.edu>, xen-devel List <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

This is a multi-part message in MIME format.
--------------070105050203000903070900
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Arun Sharma wrote:
> Keir Fraser wrote:
> 
>>
>> On 23 Jun 2005, at 17:57, Arun Sharma wrote:
>>
>>> Please apply this patch. It fixes two problems:
>>
>>
>>
>> The patch is missing. :-)
> 
> 
> I meant the patch George posted :)

There's a problem with that patch.

I think this patch is better. With George's patch (and my original 
patch) xm create -n shows (vnc 0), even when vnc=1 in the config file.

	-Arun

--------------070105050203000903070900
Content-Type: text/plain;
 name="novnc-dryrun2.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="novnc-dryrun2.patch"

diff -r 3b939e817833 tools/python/xen/xm/create.py
--- a/tools/python/xen/xm/create.py	Thu Jun 23 16:38:32 2005
+++ b/tools/python/xen/xm/create.py	Thu Jun 23 13:30:06 2005
@@ -545,7 +545,7 @@
     """If vnc was specified, spawn a vncviewer in listen mode
     and pass its address to the domain on the kernel command line.
     """
-    if not vals.vnc: return
+    if not vals.vnc or vals.dryrun: return
     vnc_display = choose_vnc_display()
     if not vnc_display:
         opts.warn("No free vnc display")

--------------070105050203000903070900
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--------------070105050203000903070900--