All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: David Lang <david.lang@digitalinsight.com>,
	Andrew Morton <akpm@osdl.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Netdev List <netdev@vger.kernel.org>
Subject: Re: [git patch] urgent e1000 fix
Date: Thu, 23 Jun 2005 19:10:42 -0400	[thread overview]
Message-ID: <42BB4172.5000904@pobox.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0506231506510.11175@ppc970.osdl.org>

Linus Torvalds wrote:
> 
> On Thu, 23 Jun 2005, Jeff Garzik wrote:
> 
>>It's probably the whitespace thing that Linus's git-apply gadget was 
>>complaining about.
>>
>>I'm terribly surprising, though, since my patch(1) applied the diff just 
>>fine.
> 
> 
> I could easily make git-apply accept empty lines as if they had a single 
> space on it. What I find surprising is that "patch" allows that kind of 
> whitespace corruption by default, and silently. Usually you have to give 
> it the "-l" flag to make it ignore whitespace differences..


patch(1) is a huge collection of heuristics like this, even without 
'-l', so I'm not surprised that it worked.

Does git-apply support patches with "fuzz", out of curiosity?

	Jeff



  reply	other threads:[~2005-06-23 23:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-23  9:24 [git patch] urgent e1000 fix Jeff Garzik
2005-06-23 21:04 ` David Lang
2005-06-23 21:19   ` Jeff Garzik
2005-06-23 22:08     ` Linus Torvalds
2005-06-23 23:10       ` Jeff Garzik [this message]
2005-06-23 23:33         ` Linus Torvalds
2005-06-24  6:49           ` Denis Vlasenko
2005-06-24  8:22             ` Keith Owens
2005-06-24  8:51               ` Linus Torvalds
2005-06-24 10:14                 ` Tomasz Kłoczko
2005-06-24 16:40                   ` Linus Torvalds
2005-06-24 15:11             ` Horst von Brand
2005-06-23 23:20     ` David Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42BB4172.5000904@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=akpm@osdl.org \
    --cc=david.lang@digitalinsight.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.