From: Jeff Garzik <jgarzik@pobox.com>
To: Ed Sweetman <safemode@comcast.net>
Cc: Pierre Ossman <drzeus-list@drzeus.cx>,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.12 breaks 8139cp
Date: Fri, 24 Jun 2005 23:15:39 -0400 [thread overview]
Message-ID: <42BCCC5B.2030901@pobox.com> (raw)
In-Reply-To: <42BCC257.5060900@comcast.net>
Ed Sweetman wrote:
> Sorry, i'm retarded, i pasted the wrong changelog line.
>
> <hch@lst.de>
> [8139TOO]: Use rtnl_lock_interruptible()
>
> The 8139too thread needs to use rtnl_lock_interruptible so it can avoid
> doing the actual work once it's been kill_proc()ed on module removal
> time.
>
> Based on debugging and an earlier patch that adds a driver-private
> semaphore from Herbert Xu.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> This seems to be the only patch that contains a change to the 8139too
> code between working and non-working code.
Please verify that reverting this patch actually fixed your problem.
$subject talks about 8139cp, but you list a change to 8139too, which are
two different drivers.
It's often wrong to focus on the driver. If a driver suddenly stops
working, that may indicate a problem in the interrupt subsystem, etc.
Jeff
next prev parent reply other threads:[~2005-06-25 3:16 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-22 21:03 2.6.12 breaks 8139cp Pierre Ossman
2005-06-22 21:34 ` Bjorn Helgaas
2005-06-23 7:50 ` Pierre Ossman
2005-06-23 12:59 ` Felipe W Damasio
2005-06-23 17:43 ` Bjorn Helgaas
2005-06-23 22:14 ` Pierre Ossman
2005-06-25 2:03 ` Ed Sweetman
2005-06-25 2:18 ` Ed Sweetman
2005-06-25 2:32 ` Ed Sweetman
2005-06-25 3:15 ` Jeff Garzik [this message]
2005-06-25 10:34 ` Pierre Ossman
2005-06-26 13:31 ` Ed Sweetman
2005-06-28 6:28 ` Pierre Ossman
2005-06-28 12:32 ` Pierre Ossman
2005-06-28 14:09 ` Kylene Jo Hall
2005-06-28 14:40 ` Pierre Ossman
2005-06-28 15:08 ` Kylene Jo Hall
2005-06-28 16:51 ` Pierre Ossman
2005-06-28 17:03 ` Kylene Jo Hall
2005-06-29 7:03 ` Pierre Ossman
2005-06-28 17:23 ` Chris Wright
2005-06-28 20:29 ` 2.6.12 breaks 8139cp [PATCH 1 of 2] Kylene Jo Hall
2005-06-28 20:34 ` Chris Wright
2005-06-28 22:10 ` Kylene Jo Hall
2005-06-29 8:22 ` Pierre Ossman
2005-06-29 14:32 ` Kylene Jo Hall
[not found] ` <20050705153512.GJ9046@shell0.pdx.osdl.net>
2005-07-07 20:01 ` Kylene Jo Hall
2005-07-08 6:14 ` Chris Wright
2005-06-28 20:30 ` 2.6.12 breaks 8139cp [PATCH 2 " Kylene Jo Hall
2005-06-23 17:17 ` 2.6.12 breaks 8139cp Roberto Oppedisano
2005-06-23 18:00 ` Bjorn Helgaas
2005-06-23 20:38 ` Ed Sweetman
2005-06-23 20:55 ` Bjorn Helgaas
2005-06-23 21:14 ` Ed Sweetman
2005-06-23 21:07 ` Roberto Oppedisano
-- strict thread matches above, loose matches on Subject: below --
2005-06-26 13:46 Nick Warne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42BCCC5B.2030901@pobox.com \
--to=jgarzik@pobox.com \
--cc=bjorn.helgaas@hp.com \
--cc=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=safemode@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.