From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Hopwood <david.nospam.hopwood@blueyonder.co.uk>
Subject: Re: [PATCH] 1 of 2: default ssid to 0
Date: Sun, 26 Jun 2005 14:55:56 +0100
Message-ID: <42BEB3EC.8090906@blueyonder.co.uk>
References: <OF925F6D60.79986553-ON8525702C.0012218A-8525702C.001254CB@us.ibm.com>
Reply-To: david.nospam.hopwood@blueyonder.co.uk
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <OF925F6D60.79986553-ON8525702C.0012218A-8525702C.001254CB@us.ibm.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Reiner Sailer wrote:
>>From: aq <aquynh@gmail.com>

>>+     for(j=0; j<= CWALL_MAX_SSIDREFS; j++)
>>+         if ((0 < j) &&( j <= CWALL_MAX_TYPES))
>>+             ssidrefs[j*CWALL_MAX_TYPES + j - 1] = htons(1);
>>+
>>
>>why dont you run the loop from j=1?
> 
> because row j=0 is the new default ssid and has no types set.
> We start with row j=1 and set the "diagonal" types to one.

I think aq's point was that the above loop is equivalent to:

   #include <stdlib.h> // for 'min'

   for (j = 1; j <= min(CWALL_MAX_SSIDREFS, CWALL_MAX_TYPES); j++) {
       ssidrefs[j*CWALL_MAX_TYPES + j - 1] = htons(1);
   }

which is arguably clearer.

-- 
David Hopwood <david.nospam.hopwood@blueyonder.co.uk>