Re: cfq build breakage

[Jeff Garzik <jgarzik@pobox.com>]

Andrew Morton wrote:
> Jeff Garzik <jgarzik@pobox.com> wrote:
> 
>>
>>In latest git tree...
>>
>>   CC [M]  drivers/block/cfq-iosched.o
>>drivers/block/cfq-iosched.c: In function `cfq_put_queue':
>>drivers/block/cfq-iosched.c:303: sorry, unimplemented: inlining failed 
>>in call to 'cfq_pending_requests': function body not available
>>drivers/block/cfq-iosched.c:1080: sorry, unimplemented: called from here
>>drivers/block/cfq-iosched.c: In function `__cfq_may_queue':
>>drivers/block/cfq-iosched.c:1955: warning: the address of 
>>`cfq_cfqq_must_alloc_slice', will always evaluate as `true'
>>make[2]: *** [drivers/block/cfq-iosched.o] Error 1
>>make[1]: *** [drivers/block] Error 2
>>make: *** [drivers] Error 2
> 
> 
> hm.  The inline thing is trivial, but the misuse of
> cfq_cfqq_must_alloc_slice() means that we now wander into untested
> territory.
> 
>  drivers/block/cfq-iosched.c |   49 +++++++++++++++++++++-----------------------
>  1 files changed, 24 insertions(+), 25 deletions(-)

FWIW I just removed the 'inline' marker, which caused a lot less 
fallout.  Jens or Nick or whomever can do a better fix later :)

	Jeff