From: Jesse Millan <jessem@cs.pdx.edu>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [PATCH] GCC4 warning: control may reach end of non-void
Date: Wed, 29 Jun 2005 04:05:09 +0000 [thread overview]
Message-ID: <42C21DF5.7020709@cs.pdx.edu> (raw)
[-- Attachment #1: Type: text/plain, Size: 1 bytes --]
[-- Attachment #2: compat-patch.patch --]
[-- Type: text/x-diff, Size: 790 bytes --]
Signed-off-by: Jesse Millan <jessem@cs.pdx.edu>
GCC complains because the function put_compat_shminfo() can't get to its return statement if there is no error... If the function does not return -EFALUT, it doesn't return anything at all. Looks like a typo.
---
diff -puN ipc/compat.c~compat-patch ipc/compat.c
--- linux-2.6.12-rc6.git10.kj.gcc4/ipc/compat.c~compat-patch 2005-06-28 20:37:20.177647168 -0700
+++ linux-2.6.12-rc6.git10.kj.gcc4-root/ipc/compat.c 2005-06-28 20:37:49.889130336 -0700
@@ -572,6 +572,7 @@ static inline int put_compat_shminfo(str
err |= __put_user(smi->shmmni, &up->shmmni);
err |= __put_user(smi->shmseg, &up->shmseg);
err |= __put_user(smi->shmall, &up->shmall);
+ return err;
}
static inline int put_compat_shm_info(struct shm_info __user *ip,
_
[-- Attachment #3: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
reply other threads:[~2005-06-29 4:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42C21DF5.7020709@cs.pdx.edu \
--to=jessem@cs.pdx.edu \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.