[KJ] [PATCH] GCC4 warning: control may reach end of non-void

[KJ] [PATCH] GCC4 warning: control may reach end of non-void

[Jesse Millan]

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: compat-patch.patch --]
[-- Type: text/x-diff, Size: 790 bytes --]


Signed-off-by: Jesse Millan <jessem@cs.pdx.edu>

GCC complains because the function put_compat_shminfo() can't get to its return statement if there is no error... If the function does not return -EFALUT, it doesn't return anything at all. Looks like a typo.
---


diff -puN ipc/compat.c~compat-patch ipc/compat.c
--- linux-2.6.12-rc6.git10.kj.gcc4/ipc/compat.c~compat-patch	2005-06-28 20:37:20.177647168 -0700
+++ linux-2.6.12-rc6.git10.kj.gcc4-root/ipc/compat.c	2005-06-28 20:37:49.889130336 -0700
@@ -572,6 +572,7 @@ static inline int put_compat_shminfo(str
 	err |= __put_user(smi->shmmni, &up->shmmni);
 	err |= __put_user(smi->shmseg, &up->shmseg);
 	err |= __put_user(smi->shmall, &up->shmall);
+	return err;
 }
 
 static inline int put_compat_shm_info(struct shm_info __user *ip,
_

[-- Attachment #3: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors