Re: [PATCH 1/2] updates for [nf|ct]netlink and event API

[Patrick McHardy <kaber@trash.net>]

Pablo Neira wrote:
> Patrick McHardy wrote:
>>
>> I think its fine, but CTA_PROTO_IPV4_{SRC,DST} should be
>> CTA_PROTO_{SRC,DST}, there's nothing related to IPv4 in them.
> 
> 
> That could be fine for nf_conntrack to differenciate between conntracks
> that represents an ipv4 and ipv6 connections.
> 
> CTA_PROTO_IPV4_SRC and CTA_PROTO_IPV6_SRC

It can do that by looking at the IP attributes (CTA_ORIG_IPV4_SRC and
CTA_IPV6_SRC).

>> Please nest all attributes related to a tuple in CTA_TUPLE
>> instead of adding them to the top-level.
> 
> Sorry, how that will look like?

You add a new nfattr header with the type set to CTA_TUPLE and
note the position of skb->tail. Then you add the nested attributes
as usual. When you're done you set the length of the nfattr header
to skb->tail - old_tail. The RTA_NEST/RTA_NEST_END macros handle
this for rtnetlink (include/linux/rtnetlink.h).

Regards
Patrick