All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roberto Nibali <ratz@drugphish.ch>
To: rv@eychenne.org
Cc: Netfilter Developers <netfilter-devel@lists.netfilter.org>,
	Patrick Schaaf <bof@bof.de>
Subject: Re: possible issues with blowing up struct ipt_log_info
Date: Fri, 01 Jul 2005 09:08:24 +0200	[thread overview]
Message-ID: <42C4EBE8.7050804@drugphish.ch> (raw)
In-Reply-To: <20050629160923.GF3331@eychenne.org>

> I remember saying here that it would be cool to have the log prefix length
> tunable at kernel LOG module insertion, have it exported (read-only) to some
> /proc entry, and have userspace (iptables, or any other upper-level
> application) rely on the real-time extracted value.
> What do you think?

Could work, although I'm not sure why you'd want to change the prefix 
lenght that often, however flexibility is nice.

Another issue I see is that iptables, when sending the data from user to 
kernel space, must be made aware of setting the correct target{info}size 
in case the ipt_*LOG module is not loaded yet. Parsing proc-fs would be 
useless. This opens a possible "DoS", which can be addressed by having a 
max log prefix length accepted as being passed to the lkm.

Was there any consensus regarding this feature among the core netfilter 
developers or has anyone posted a POC patch? Granted, there are a 
billion more important things to address, but still ... ;)

Regards,
Roberto Nibali, ratz
-- 
echo 
'[q]sa[ln0=aln256%Pln256/snlbx]sb3135071790101768542287578439snlbxq' | dc

  reply	other threads:[~2005-07-01  7:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-29 15:37 possible issues with blowing up struct ipt_log_info Roberto Nibali
2005-06-29 15:40 ` Patrick Schaaf
2005-06-29 16:08   ` Roberto Nibali
2005-06-29 16:09   ` Herve Eychenne
2005-07-01  7:08     ` Roberto Nibali [this message]
2005-07-03 12:36     ` Harald Welte
2005-07-03 22:05       ` Herve Eychenne
2005-07-04  5:55         ` Patrick Schaaf
2005-07-04  8:20           ` Roberto Nibali
2005-07-04  8:59             ` Harald Welte
2005-07-04  9:26               ` Roberto Nibali
2005-07-04  9:53                 ` Harald Welte
2005-07-04 10:13                   ` Roberto Nibali
2005-07-04 10:08             ` Herve Eychenne
2005-07-04 10:48               ` Roberto Nibali
2005-07-04 11:21                 ` Herve Eychenne
2005-07-04  9:23           ` Herve Eychenne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42C4EBE8.7050804@drugphish.ch \
    --to=ratz@drugphish.ch \
    --cc=bof@bof.de \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=rv@eychenne.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.