From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1DphVo-0008IT-UD for mharc-grub-devel@gnu.org; Tue, 05 Jul 2005 03:06:33 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DphVm-0008Gs-9i for grub-devel@gnu.org; Tue, 05 Jul 2005 03:06:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DphVk-0008En-EZ for grub-devel@gnu.org; Tue, 05 Jul 2005 03:06:29 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DphVk-0008EU-2N for grub-devel@gnu.org; Tue, 05 Jul 2005 03:06:28 -0400 Received: from [217.12.11.36] (helo=smtp005.mail.ukl.yahoo.com) by monty-python.gnu.org with smtp (Exim 4.34) id 1DphZB-0002O2-B3 for grub-devel@gnu.org; Tue, 05 Jul 2005 03:10:01 -0400 Received: (qmail 44248 invoked from network); 5 Jul 2005 07:03:51 -0000 Received: from unknown (HELO ?192.168.0.2?) (subdino2004@83.194.40.149 with plain) by smtp005.mail.ukl.yahoo.com with SMTP; 5 Jul 2005 07:03:51 -0000 Message-ID: <42CA30D6.6010707@yahoo.fr> Date: Tue, 05 Jul 2005 09:03:50 +0200 From: Vincent Pelletier User-Agent: Debian Thunderbird 1.0.2 (X11/20050602) X-Accept-Language: en-us, en MIME-Version: 1.0 To: The development of GRUB 2 References: <42C84FF8.8020102@yahoo.fr> <42C94B8A.2070709@yahoo.fr> <200507050110.43155.okuji@enbug.org> In-Reply-To: <200507050110.43155.okuji@enbug.org> X-Enigmail-Version: 0.91.0.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Bulk] [PATCH] Small unicode problem fix in normal/menu.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2005 07:06:31 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Yoshinori K. Okuji wrote: > My feeling is that it is not convenient to use pointers. Right. My first idea was to use a struct as return type : struct coords { unsigned char x; unsigned char y; }; So it becomes : if (grub_getxy () .x) Or maybe a struct of bitfields... I feel structs as being cleaner to use compared to shifts. If someday we have a terminal that exceeds 255 chars in one or both dimensions, we wouldn't have to grep "grub_getxy ()" to find the shifts... Vincent Pelletier -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFCyjDWFEQoKRQyjtURAg5+AKCv+0nJXOMzaiiQ/+ePXVAOhuvvlgCeN88f 40Oy4FUN5ihK0USgAUl7ypE= =M1Xj -----END PGP SIGNATURE----- ___________________________________________________________________________ Appel audio GRATUIT partout dans le monde avec le nouveau Yahoo! Messenger Téléchargez cette version sur http://fr.messenger.yahoo.com