All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vladimir V. Saveliev" <vs@namesys.com>
To: Jeff Mahoney <jeffm@suse.com>
Cc: Hans Reiser <reiser@namesys.com>,
	ReiserFS List <reiserfs-list@namesys.com>
Subject: Re: [PATCH] reiserfs: reformat code with Lindent
Date: Fri, 08 Jul 2005 00:53:36 +0400	[thread overview]
Message-ID: <42CD9650.6040401@namesys.com> (raw)
In-Reply-To: <42CD8CC6.4000808@suse.com>

[-- Attachment #1: Type: text/plain, Size: 918 bytes --]

Hello

Jeff Mahoney wrote:
> Hey all -
> 
> Just out of curiousity, does anyone outside of Chris and I have
> outstanding patches against ReiserFS? 

I have no idea how the attached patch managed to not get included.

I ask because the tree has been
> relatively stable for some time and I wonder if it may be time to submit
> a Lindent patch to clean up the code and reformat it to adhere to the
> kernel style guidelines.
> 
> I've posted a patch[1] that is only the output of the Lindent script.
> Ideally, there should be some string formatting in there as well, but
> I'd like to split them up into separate pieces so we know each chunk is
> correct. Sorry I couldn't attach it - it was rejected by the list since
> it is over 128k in size.
> 
> Opinions?
> 
> -Jeff
> [1]:
> ftp://ftp.suse.com/pub/people/jeffm/reiserfs/kernel-v2.6/cleanups/2.6.13-rc2/01-reiserfs-lindent.diff
> 
> --
> Jeff Mahoney
> SuSE Labs

[-- Attachment #2: reiserfs-old-read-bitmap.patch --]
[-- Type: text/plain, Size: 1031 bytes --]

 fs/reiserfs/super.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -puN fs/reiserfs/super.c~reiserfs-old-read-bitmap fs/reiserfs/super.c
--- linux-2.6.12/fs/reiserfs/super.c~reiserfs-old-read-bitmap	2005-07-08 00:51:07.171918740 +0400
+++ linux-2.6.12-vs/fs/reiserfs/super.c	2005-07-08 00:51:54.185318407 +0400
@@ -1286,11 +1286,11 @@ static int read_old_bitmaps (struct supe
   int bmp1 = (REISERFS_OLD_DISK_OFFSET_IN_BYTES / s->s_blocksize) + 1;  /* first of bitmap blocks */
 
   /* read true bitmap */
-  SB_AP_BITMAP (s) = vmalloc (sizeof (struct reiserfs_buffer_info *) * sb_bmap_nr(rs));
+  SB_AP_BITMAP (s) = vmalloc (sizeof (struct reiserfs_bitmap_info) * sb_bmap_nr(rs));
   if (SB_AP_BITMAP (s) == 0)
     return 1;
 
-  memset (SB_AP_BITMAP (s), 0, sizeof (struct reiserfs_buffer_info *) * sb_bmap_nr(rs));
+  memset (SB_AP_BITMAP (s), 0, sizeof (struct reiserfs_bitmap_info) * sb_bmap_nr(rs));
 
   for (i = 0; i < sb_bmap_nr(rs); i ++) {
     SB_AP_BITMAP (s)[i].bh = sb_bread (s, bmp1 + i);

_

  parent reply	other threads:[~2005-07-07 20:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-07 20:12 [PATCH] reiserfs: reformat code with Lindent Jeff Mahoney
2005-07-07 20:24 ` Hans Reiser
2005-07-07 20:53 ` Vladimir V. Saveliev [this message]
2005-07-07 21:09   ` Jeff Mahoney
2005-07-07 21:17     ` Vladimir V. Saveliev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42CD9650.6040401@namesys.com \
    --to=vs@namesys.com \
    --cc=jeffm@suse.com \
    --cc=reiser@namesys.com \
    --cc=reiserfs-list@namesys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.