From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hopwood Subject: Re: [PATCH] make shadow code compile ok on FC4 which is using gcc4 Date: Tue, 12 Jul 2005 00:32:30 +0100 Message-ID: <42D3018E.7000305@blueyonder.co.uk> References: <16A54BF5D6E14E4D916CE26C9AD30575029F0BB7@pdsmsx402.ccr.corp.intel.com> <42D2C65E.5000601@blueyonder.co.uk> Reply-To: david.nospam.hopwood@blueyonder.co.uk Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Rik van Riel wrote: > On Mon, 11 Jul 2005, David Hopwood wrote: >>Li, Xin B wrote: >> >>>We need this patch to make shadow code compile ok on FC4 which is using >>>gcc4. >> >>Given gcc4's propensity to warn about things that are often harmless, is >>it still a good idea to be compiling with -Werror? > > Fixing a compile warning is very little effort, but hunting > the occasional (1 in 50?) real bug can be extremely time > consuming. I'm not suggesting that compiler warnings shouldn't be fixed; I'm suggesting that they shouldn't break the build. -- David Hopwood