From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1DsIxg-0007Hf-Mb for mharc-grub-devel@gnu.org; Tue, 12 Jul 2005 07:30:05 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DsIvt-0006p0-Dq for grub-devel@gnu.org; Tue, 12 Jul 2005 07:28:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DsIvd-0006fn-Ri for grub-devel@gnu.org; Tue, 12 Jul 2005 07:27:59 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DsIvc-0006cE-I3 for grub-devel@gnu.org; Tue, 12 Jul 2005 07:27:56 -0400 Received: from [217.12.11.32] (helo=smtp001.mail.ukl.yahoo.com) by monty-python.gnu.org with smtp (Exim 4.34) id 1DsIqc-0003U1-LH for grub-devel@gnu.org; Tue, 12 Jul 2005 07:22:46 -0400 Received: (qmail 89537 invoked from network); 12 Jul 2005 11:14:55 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.fr; h=Received:Message-ID:Date:From:User-Agent:X-Accept-Language:MIME-Version:To:Subject:References:In-Reply-To:X-Enigmail-Version:Content-Type:Content-Transfer-Encoding; b=gHKXIHybEEAzwy1G2lx4k+j3p1fh0tN/lRT3zAIrK6ykW6AlyXhb6NZErurq/zTrvCwjrYgJn1Gf33VWhrcZdbMUCGZJBX5cYKnwV4fRk/HE+mn0gvQmV17CBMJL3eAHh2cZUevOJUCCAnzokndkCv/dW/os5GUCPVCXzhNAj6s= ; Received: from unknown (HELO ?192.168.0.2?) (subdino2004@83.194.179.151 with plain) by smtp001.mail.ukl.yahoo.com with SMTP; 12 Jul 2005 11:14:55 -0000 Message-ID: <42D3A631.50409@yahoo.fr> Date: Tue, 12 Jul 2005 13:14:57 +0200 From: Vincent Pelletier User-Agent: Debian Thunderbird 1.0.2 (X11/20050602) X-Accept-Language: en-us, en MIME-Version: 1.0 To: The development of GRUB 2 References: <42D26452.3010706@yahoo.fr> <42D26FA4.3010907@inma.ucl.ac.be> In-Reply-To: <42D26FA4.3010907@inma.ucl.ac.be> X-Enigmail-Version: 0.91.0.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] Huge changes in mm.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2005 11:30:01 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Vincent Guffens wrote: > Vincent Pelletier wrote: > It must be released by the one who called the malloc. I don't see any good reason to forget - on kernel side - this chunk, as we still keep the struct member in memory. Anyway, I've done some other major changes to this patch, now the chunks are a simple chained list. That prevents bugs like thinking the first chunk is right after the last one in memory. The new code is also much lighter on dprintf. I'll send a patch when I'll have solved what I think is the last bug which only triggers on x86: malloc returns sometime out of region pointers... > grub_size_t n = ((size + GRUB_MM_ALIGN - 1) >> GRUB_MM_ALIGN_LOG2) + 1; > which adds the extra block for the header. I prefer relying on sizeof when it comes to allocating space instead of such formula. If we ever change the struct size, it would break in a strange way - like all memory allocation problems. Vincent Pelletier -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFC06YxFEQoKRQyjtURArzOAKCfGiIOe2uRirlH5UxRum2YzKwXXQCfdxua ra/FrNuwvA+rG3GpWt7mtZw= =UP6z -----END PGP SIGNATURE----- ___________________________________________________________________________ Appel audio GRATUIT partout dans le monde avec le nouveau Yahoo! Messenger Téléchargez cette version sur http://fr.messenger.yahoo.com