From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1DsS3g-0006Za-4c for mharc-grub-devel@gnu.org; Tue, 12 Jul 2005 17:12:52 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DsS3d-0006Y4-Tj for grub-devel@gnu.org; Tue, 12 Jul 2005 17:12:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DsS3V-0006TS-5m for grub-devel@gnu.org; Tue, 12 Jul 2005 17:12:48 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DsS0e-0004U1-PH for grub-devel@gnu.org; Tue, 12 Jul 2005 17:09:44 -0400 Received: from [217.12.11.32] (helo=smtp001.mail.ukl.yahoo.com) by monty-python.gnu.org with smtp (Exim 4.34) id 1DsRoE-0008GP-I1 for grub-devel@gnu.org; Tue, 12 Jul 2005 16:56:54 -0400 Received: (qmail 32629 invoked from network); 12 Jul 2005 20:48:57 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.fr; h=Received:Message-ID:Date:From:User-Agent:X-Accept-Language:MIME-Version:To:Subject:References:In-Reply-To:X-Enigmail-Version:Content-Type:Content-Transfer-Encoding; b=ZTtUfvWHhSmn6Q75wv9W4N2LWwXHMMrggkybdaj7GNGMddPRHev+U6vsqX2cSM2dL7QKJgVpsHCogh59+lhBOmqG3yp2y19VquhZyG8dS7oLFmF196FF8QekGf3tpUa7twrNM/VTaGMkQrPi5A4nF5pYvqkFVg8VSevMGCfsFAY= ; Received: from unknown (HELO ?192.168.0.2?) (subdino2004@83.194.179.151 with plain) by smtp001.mail.ukl.yahoo.com with SMTP; 12 Jul 2005 20:48:56 -0000 Message-ID: <42D42CC1.80301@yahoo.fr> Date: Tue, 12 Jul 2005 22:49:05 +0200 From: Vincent Pelletier User-Agent: Debian Thunderbird 1.0.2 (X11/20050602) X-Accept-Language: en-us, en MIME-Version: 1.0 To: The development of GRUB 2 References: <42D26452.3010706@yahoo.fr> <200507121258.40668.okuji@enbug.org> <42D3B827.4090103@yahoo.fr> <87hdf0p4jy.fsf@student.han.nl> <42D3C877.3040607@yahoo.fr> <5b8d0feefaf6717dc015cc834de2da1b@penguinppc.org> <877jfwowlo.fsf@student.han.nl> <42D41013.4040601@yahoo.fr> <87y88bolt3.fsf@student.han.nl> In-Reply-To: <87y88bolt3.fsf@student.han.nl> X-Enigmail-Version: 0.91.0.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: sparc64 port : diffs to powerpc branches X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2005 21:12:50 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Marco Gerards wrote: > This is an important test. Please do not remove it so this code can > be shared. Just make sure GRUB_IEEE1275_FLAG_NO_PARTITION_0 is set or > not set, depending on how OB works. No problem, I removed it to show that it isn't needed for usparc. > Can this be done in a way that we can share most (all?) headers > related to ieee 1275? I think so, except for some special function, like the term colour one (I don't think usparc can change colour... Or at least not the same way ppc does.) >>Changed some suspicious "&string" to just "string". Some function with void * arguments were actualy receiving char *[]. There was no warning about it, but I think there was a leak. I changed them to char * (dynamically allocated, see next remark :) ). >>Added malloc calls when size can be known. > Nice! More can be done, I haven't done it everywhere. > Can you write the code so it works on both the PPC and sparc so this > code can be shared? Some code you disabled like this has a function > on the PPC, IIRC. I think that function works on usparc (not sure though) but as it is not used at all, I commented it (to get some remarks about it so I can guess what it's used for :) ). >>Remove ppc specific partition numbering thing. > Can you explain this? It seems that ppc numbers his partitions a special way (ruled by a flag, so we can make it common to both if the flag is correctly set). > When you implement this, you can support switching from normal to > rescue mode and back properly. There should be a bug in the x86 implementation, that would explain the unaligned pointer I get when switching to rescue mode from normal mode. > grub-mkimage is used to add modules to grubof. So this works, sun partition label & ext2 is read. > Do you want me to fully review the complete patch or was it just a > reference for your description? I think you shouldn't. Once the common parts will have been extracted a real patch with changelog will be edited. Vincent Pelletier -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFC1CzBFEQoKRQyjtURAicmAJ9ElgCCIk8uxl5K3CVzxejvt/Tz7QCfTyXC qfT6xq2HLEtGILe/ved1JYA= =fWNO -----END PGP SIGNATURE----- ___________________________________________________________________________ Appel audio GRATUIT partout dans le monde avec le nouveau Yahoo! Messenger Téléchargez cette version sur http://fr.messenger.yahoo.com