* [KJ] [PATCH] drivers/usb/input/ati_remote.c : Use of time_after and
@ 2005-07-13 5:51 Marcelo Feitoza Parisi
2005-07-16 7:04 ` [KJ] [PATCH] drivers/usb/input/ati_remote.c : Use of the Marcelo Feitoza Parisi
0 siblings, 1 reply; 2+ messages in thread
From: Marcelo Feitoza Parisi @ 2005-07-13 5:51 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1 bytes --]
[-- Attachment #2: ati_remote.patch --]
[-- Type: text/x-patch, Size: 1917 bytes --]
Use of time_after and time_before macros, defined at linux/jiffies.h, which deal
with wrapping correctly and are nicer to read.
Signed-off-by: Marcelo Feitoza Parisi <marcelo@feitoza.com.br>
--- linux/drivers/usb/input/ati_remote.c 2005-07-07 19:11:55.000000000 -0300
+++ linux-kj/drivers/usb/input/ati_remote.c 2005-07-13 02:49:17.210994184 -0300
@@ -95,6 +95,7 @@
#include <linux/input.h>
#include <linux/usb.h>
#include <linux/wait.h>
+#include <linux/jiffies.h>
/*
* Module and Version Information, Module Parameters
@@ -510,16 +511,22 @@
* pad down, so we increase acceleration, ramping up over two seconds to
* a maximum speed. The acceleration curve is #defined above.
*/
- if ((jiffies - ati_remote->old_jiffies) > (HZ >> 2)) {
+ if (time_after(jiffies, ati_remote->old_jiffies + (HZ >> 2))) {
acc = 1;
ati_remote->acc_jiffies = jiffies;
}
- else if ((jiffies - ati_remote->acc_jiffies) < (HZ >> 3)) acc = accel[0];
- else if ((jiffies - ati_remote->acc_jiffies) < (HZ >> 2)) acc = accel[1];
- else if ((jiffies - ati_remote->acc_jiffies) < (HZ >> 1)) acc = accel[2];
- else if ((jiffies - ati_remote->acc_jiffies) < HZ ) acc = accel[3];
- else if ((jiffies - ati_remote->acc_jiffies) < HZ+(HZ>>1)) acc = accel[4];
- else if ((jiffies - ati_remote->acc_jiffies) < (HZ << 1)) acc = accel[5];
+ else if (time_before(jiffies, ati_remote->acc_jiffies + (HZ >> 3)))
+ acc = accel[0];
+ else if (time_before(jiffies, ati_remote->acc_jiffies + (HZ >> 2)))
+ acc = accel[1];
+ else if (time_before(jiffies, ati_remote->acc_jiffies + (HZ >> 1)))
+ acc = accel[2];
+ else if (time_before(jiffies, ati_remote->acc_jiffies + HZ ))
+ acc = accel[3];
+ else if (time_before(jiffies, ati_remote->acc_jiffies + HZ+(HZ>>1)))
+ acc = accel[4];
+ else if (time_before(jiffies, ati_remote->acc_jiffies + (HZ << 1)))
+ acc = accel[5];
else acc = accel[6];
input_regs(dev, regs);
[-- Attachment #3: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-07-16 7:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-13 5:51 [KJ] [PATCH] drivers/usb/input/ati_remote.c : Use of time_after and Marcelo Feitoza Parisi
2005-07-16 7:04 ` [KJ] [PATCH] drivers/usb/input/ati_remote.c : Use of the Marcelo Feitoza Parisi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.