All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Drake <dsd@gentoo.org>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Netdev <netdev@oss.sgi.com>, Ayaz Abdulla <AAbdulla@nvidia.com>
Subject: Re: [PATCH] forcedeth: TX handler changes (experimental)
Date: Sat, 16 Jul 2005 22:24:57 +0100	[thread overview]
Message-ID: <42D97B29.4050400@gentoo.org> (raw)
In-Reply-To: <42D9658B.7020907@gentoo.org>

Daniel Drake wrote:
> After applying the v0.38 patch, I can't get any network at all. DHCP 
> fails to get an IP. v0.37 works fine.

Tracked it down. (sorry for linewraps)

+#define DEV_NEED_TIMERIRQ	0x0001  /* set the timer irq flag in the irq mask */
+#define DEV_NEED_LINKTIMER	0x0002	/* poll link settings. Relies on the timer 
irq */
+#define DEV_HAS_LARGEDESC	0x0003	/* device supports jumbo frames and needs 
packet format 2 */

My hardware is NEED_TIMERIRQ|NEED_LINKTIMER, however, by this logic, it'll 
also be DEV_HAVE_LARGEDESC, which isn't true.

So, you want this instead:

#define DEV_HAS_LARGEDESC	0x0004

After making that change, all is working fine, but then again, I've never run 
into the hangs you are debugging. I'll follow up in a couple of days time to 
confirm I'm not getting any problems with the new code.

Thanks,
Daniel

  reply	other threads:[~2005-07-16 21:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-16 14:04 [PATCH] forcedeth: TX handler changes (experimental) Manfred Spraul
2005-07-16 19:52 ` Daniel Drake
2005-07-16 19:52 ` Daniel Drake
2005-07-16 21:24   ` Daniel Drake [this message]
2005-07-16 21:36     ` Manfred Spraul
2005-07-16 21:36     ` Manfred Spraul
2005-07-20 21:16       ` Daniel Drake
2005-07-20 21:16       ` Daniel Drake
2005-07-16 21:24   ` Daniel Drake
  -- strict thread matches above, loose matches on Subject: below --
2005-07-16 14:05 Manfred Spraul
2005-07-16 16:16 ` Daniel Drake
2005-07-16 16:49   ` Manfred Spraul
2005-07-16 16:49   ` Manfred Spraul
2005-07-16 14:04 Manfred Spraul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42D97B29.4050400@gentoo.org \
    --to=dsd@gentoo.org \
    --cc=AAbdulla@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.