Re: [PATCH 1/5] reiserfs: use more consistent printk formatting

[Hans Reiser <reiser@namesys.com>]

Jeff Mahoney wrote:

> Hans Reiser wrote:
>
> >Jeff Mahoney wrote:
>
> >>The output format between a warning/error/panic/info/etc changes with
> >>which one is used.
> >>
> >>The following patch makes the messages more internally consistent,
> but also
> >>more consistent with other Linux filesystems.
> >>
> >>Signed-off-by: Jeff Mahoney <jeffm@suse.com>
> >>diff -ruNpX dontdiff linux-2.6.13-rc3/fs/reiserfs/prints.c
> linux-2.6.13-rc3.errors/fs/reiserfs/prints.c
> >>--- linux-2.6.13-rc3/fs/reiserfs/prints.c    2005-07-13
> 13:57:32.000000000 -0400
> >>+++ linux-2.6.13-rc3.errors/fs/reiserfs/prints.c    2005-07-14
> 16:36:47.000000000 -0400
> >>@@ -269,10 +269,10 @@ void reiserfs_warning(struct super_block
> >>{
> >>    do_reiserfs_warning(fmt);
> >>    if (sb)
> >>-        printk(KERN_WARNING "ReiserFS: %s: warning: %s\n",
> >>-               reiserfs_bdevname(sb), error_buf);
> >>+        printk(KERN_WARNING "REISERFS warning (device %s): %s\n",
> >>+               sb->s_id, error_buf);
> >>    else
> >>-        printk(KERN_WARNING "ReiserFS: warning: %s\n", error_buf);
> >>+        printk(KERN_WARNING "REISERFS warning: %s\n", error_buf);
> >>
> >>
> >why are you changing it to the harder to read all upper case?  It is
> >known from various studies that all uppercase is harder for users to
> read.
>
>
> My argument is that it makes the subsystem more prominent in a quick
> visual search, and is easier on the eyes than the mixed case variant.

Please used mixed case, see literature on all uppercase for why.


Thanks for your other changes.

>
> -Jeff
>
> --
> Jeff Mahoney
> SuSE Labs