Re: [PATCH] conntrack-event-api

[Roberto Nibali <ratz@tac.ch>]

> Here's a revamped conntrack-event-api patch.  Instead of using
> skb->nfcache, we now use a per-cpu data structure.  This saves 32bit in
> sk_buff.

I see that netconf really gets the ball rolling ;).

> +static inline void 
> +ip_conntrack_event_cache(enum ip_conntrack_events event,
> +			 const struct sk_buff *skb)
> +{
> +	struct ip_conntrack_ecache *ecache = 
> +					&__get_cpu_var(ip_conntrack_ecache);
> +
> +	if (unlikely((struct ip_conntrack *) skb->nfct != ecache->ct)) {
> +		if (net_ratelimit()) {
> +			printk(KERN_ERR "ctevent: skb->ct != ecache->ct !!!\n");

Not important, but: s/skb->ct/skb->nfct/ and could you maybe drop the
!!!'s? ;)

> +			dump_stack();

Is this trace reliable regarding per-CPU structures?

Regards,
Roberto Nibali, ratz
-- 
-------------------------------------------------------------
addr://Rathausgasse 31, CH-5001 Aarau  tel://++41 62 823 9355
http://www.terreactive.com             fax://++41 62 823 9356
-------------------------------------------------------------
terreActive AG                       Wir sichern Ihren Erfolg
-------------------------------------------------------------