All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Hugh Dickins <hugh@veritas.com>
Cc: ncunningham@cyclades.com,
	Linux Memory Management <linux-mm@kvack.org>,
	Pavel Machek <pavel@suse.cz>,
	William Lee Irwin III <wli@holomorphy.com>
Subject: Re: PageReserved removal from swsusp
Date: Tue, 26 Jul 2005 09:29:10 +1000	[thread overview]
Message-ID: <42E575C6.2010802@yahoo.com.au> (raw)
In-Reply-To: <Pine.LNX.4.61.0507251332010.13673@goblin.wat.veritas.com>

Hugh Dickins wrote:
> On Mon, 25 Jul 2005, Nick Piggin wrote:
> 
>>However I'm not sure that I really like the use of
>>flags == 0xffffffff to indicate the page is unusable. For one thing it
>>may confuse things that walk physical pages, and for another it can
>>easily break if someone clears a flag of an 'unusable' page.
> 
> 
> I don't like that either.  Setting all the flags seems to maximize the
> chance of error somewhere.  Perhaps a magic number in one of the other
> struct page fields would work more safely.  Or perhaps just leave it
> as its own flag bit for now, and later go on a separate free-up-some-
> flags exercise.
> 

OK I'll leave it using PageReserved, and we can rethink it later.

-- 
SUSE Labs, Novell Inc.

Send instant messages to your online friends http://au.messenger.yahoo.com 
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2005-07-25 23:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-25  1:38 PageReserved removal from swsusp Nick Piggin
2005-07-25  4:31 ` Nigel Cunningham
2005-07-25  4:52   ` Nick Piggin
2005-07-25  6:22     ` Nick Piggin
2005-07-25  6:59       ` Pavel Machek
2005-07-25 12:39       ` Hugh Dickins
2005-07-25 23:29         ` Nick Piggin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42E575C6.2010802@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=hugh@veritas.com \
    --cc=linux-mm@kvack.org \
    --cc=ncunningham@cyclades.com \
    --cc=pavel@suse.cz \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.