From: Peter Staubach <staubach@redhat.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH NFS 3/3] Replace nfs_block_bits() with roundup_pow_of_two()
Date: Tue, 26 Jul 2005 16:00:33 -0400 [thread overview]
Message-ID: <42E69661.10700@redhat.com> (raw)
In-Reply-To: <1122400127.6894.32.camel@lade.trondhjem.org>
Trond Myklebust wrote:
>må den 25.07.2005 Klokka 17:56 (+0200) skreiv Rene Scharfe:
>
>
>
>>What's your opinion of the following patch, which explicitly states the
>>intent of nfs_block_bits()? It still needs patch 1 and 2.
>>
>>
>
>I really don't like the choice of name. If you feel you must change the
>name, then make it something like nfs_blocksize_align(). That describes
>its function, instead of the implementation details.
>
I would agree. Was there really a driving requirement to change the name?
Thanx...
ps
next prev parent reply other threads:[~2005-07-26 20:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-24 14:36 [PATCH NFS 3/3] Replace nfs_block_bits() with roundup_pow_of_two() Rene Scharfe
2005-07-24 23:09 ` Trond Myklebust
2005-07-24 23:24 ` Trond Myklebust
2005-07-25 15:56 ` Rene Scharfe
2005-07-26 17:48 ` Trond Myklebust
2005-07-26 20:00 ` Peter Staubach [this message]
2005-07-26 20:42 ` Rene Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42E69661.10700@redhat.com \
--to=staubach@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rene.scharfe@lsrfire.ath.cx \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.